From 3a41f69f9ce1ab778112c0727a69a753fe36c77a Mon Sep 17 00:00:00 2001 From: Janic Duplessis Date: Thu, 22 Oct 2020 17:53:51 -0700 Subject: [PATCH] Make sure js bundle still exists at bundle-output path (#30149) Summary: Since changes to support hermes on iOS the js bundled is moved away from the location where it is generated when calling metro. This causes issues with the RN sentry integration since it relies on intercepting this path to find the bundle file after running react-native-xcode.sh. Seems kind of like a hacky way to get the bundle location, but let's avoid breaking it. https://github.com/getsentry/sentry-cli/blob/master/src/commands/react_native_xcode.rs ## Changelog [iOS] [Fixed] - Make sure js bundle still exists at bundle-output path Pull Request resolved: https://github.com/facebook/react-native/pull/30149 Test Plan: Checked that the bundle file exists both at bundle-output path and in the .app. Checked that the sentry release script works. Reviewed By: cpojer Differential Revision: D24480115 Pulled By: appden fbshipit-source-id: c01c80d47ed54319f97063ec635c021552a95c22 --- scripts/react-native-xcode.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/react-native-xcode.sh b/scripts/react-native-xcode.sh index eeb601653f3b7f..fcc60ef7cabd82 100755 --- a/scripts/react-native-xcode.sh +++ b/scripts/react-native-xcode.sh @@ -168,7 +168,7 @@ fi $EXTRA_PACKAGER_ARGS if [[ $USE_HERMES != true ]]; then - mv "$BUNDLE_FILE" "$DEST/" + cp "$BUNDLE_FILE" "$DEST/" BUNDLE_FILE="$DEST/main.jsbundle" else EXTRA_COMPILER_ARGS=