-
Notifications
You must be signed in to change notification settings - Fork 24.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Make sure the -DANDROID compilation flag is always included. (#37451)
Summary: Pull Request resolved: #37451 It seems like starting from AGP 7.4, Android is not including the `-DANDROID` flag anymore from the NDK toolchain. As we do have several `#ifdef` logic that takes care of having this macro set, I'm going to make sure it's always set for both ReactAndroid, hermes-engine and the template. Changelog: [Android] [Fixed] - Make sure the -DANDROID compilation flag is always included Reviewed By: javache Differential Revision: D45908787 fbshipit-source-id: 07284712d7bcce73dc8ea0dffd4a9d00af4de1d2
- Loading branch information
1 parent
f7dcc65
commit 3a321ae
Showing
4 changed files
with
16 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters