Skip to content

Commit 34f9cb9

Browse files
author
Adam Comella
committed
Add TODO comment for bug shergin spotted
1 parent 20100d0 commit 34f9cb9

File tree

1 file changed

+8
-0
lines changed

1 file changed

+8
-0
lines changed

ReactAndroid/src/main/java/com/facebook/react/uimanager/ReactShadowNodeImpl.java

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -180,6 +180,14 @@ public void dirty() {
180180
} else if (getParent() != null) {
181181
// Virtual nodes aren't involved in layout but they need to have the dirty signal
182182
// propagated to their ancestors.
183+
//
184+
// TODO: There are some edge cases that currently aren't supported. For example, if the size
185+
// of your inline image/view changes, its size on-screen is not be updated. Similarly,
186+
// if the size of a view inside of an inline view changes, its size on-screen is not
187+
// updated. The problem may be that dirty propagation stops at inline views because the
188+
// parent of each inline view is null. A possible fix would be to implement an `onDirty`
189+
// handler in Yoga that will propagate the dirty signal to the ancestors of the inline view.
190+
//
183191
getParent().dirty();
184192
}
185193
}

0 commit comments

Comments
 (0)