-
Notifications
You must be signed in to change notification settings - Fork 24.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
introduce native api to access RuntimeExecutor (#42758)
Summary: Pull Request resolved: #42758 Changelog: [iOS][Added] - introduce native api to access RuntimeExecutor The goal of this API is to provide a safe way to access the `jsi::runtime` in bridgeless mode. The decision to limit access to the runtime in bridgeless was a conscious one - the runtime pointer is not thread-safe and its lifecycle must be managed correctly by owners. However, interacting with the runtime is an advanced use case we would want to support. Our recommended ways to access the runtime in bridgeless mode is either 1) via the RuntimeExecutor, or 2) via a C++ TurboModule. This diff introduces the API that would allow for 1). The integration consists of these parts: - wrapper object for RuntimeExecutor access, `RCTRuntimeExecutor`. The NSObject wrapper is necessary so we can make it the property of a swift module - new protocol API,`RCTRuntimeExecutionModule`, for modules to access the RuntimeExecutor block - integration within the bridgeless infrastructure Reviewed By: javache Differential Revision: D53256188 fbshipit-source-id: 8fadbe8f760cdb8928bbf3f7e4829e27b7617b9d
- Loading branch information
1 parent
db066ac
commit 343a0d3
Showing
6 changed files
with
115 additions
and
2 deletions.
There are no files selected for viewing
18 changes: 18 additions & 0 deletions
18
packages/react-native/React/Base/RCTRuntimeExecutorModule.h
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
/* | ||
* Copyright (c) Meta Platforms, Inc. and affiliates. | ||
* | ||
* This source code is licensed under the MIT license found in the | ||
* LICENSE file in the root directory of this source tree. | ||
*/ | ||
|
||
@class RCTRuntimeExecutor; | ||
|
||
/** | ||
* Have your module conform to this protocol to access the RuntimeExecutor. | ||
* Only available in the bridgeless runtime. | ||
*/ | ||
@protocol RCTRuntimeExecutorModule <NSObject> | ||
|
||
@property (nonatomic, nullable, readwrite) RCTRuntimeExecutor *runtimeExecutor; | ||
|
||
@end |
30 changes: 30 additions & 0 deletions
30
...-native/ReactCommon/react/nativemodule/core/platform/ios/ReactCommon/RCTRuntimeExecutor.h
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
/* | ||
* Copyright (c) Meta Platforms, Inc. and affiliates. | ||
* | ||
* This source code is licensed under the MIT license found in the | ||
* LICENSE file in the root directory of this source tree. | ||
*/ | ||
|
||
#import <ReactCommon/RuntimeExecutor.h> | ||
#import <jsi/jsi.h> | ||
|
||
NS_ASSUME_NONNULL_BEGIN | ||
|
||
typedef void (^RCTJSIRuntimeHandlingBlock)(facebook::jsi::Runtime &runtime); | ||
|
||
@interface RCTRuntimeExecutor : NSObject | ||
|
||
- (instancetype)init NS_UNAVAILABLE; | ||
|
||
/** | ||
Initializes an object that wraps ways to access the RuntimeExecutor. | ||
@param runtimeExecutor The instance of RuntimeExecutor. | ||
*/ | ||
- (instancetype)initWithRuntimeExecutor:(facebook::react::RuntimeExecutor)runtimeExecutor NS_DESIGNATED_INITIALIZER; | ||
|
||
- (void)execute:(RCTJSIRuntimeHandlingBlock)block; | ||
|
||
@end | ||
|
||
NS_ASSUME_NONNULL_END |
34 changes: 34 additions & 0 deletions
34
...native/ReactCommon/react/nativemodule/core/platform/ios/ReactCommon/RCTRuntimeExecutor.mm
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
/* | ||
* Copyright (c) Meta Platforms, Inc. and affiliates. | ||
* | ||
* This source code is licensed under the MIT license found in the | ||
* LICENSE file in the root directory of this source tree. | ||
*/ | ||
|
||
#import "RCTRuntimeExecutor.h" | ||
|
||
@implementation RCTRuntimeExecutor { | ||
facebook::react::RuntimeExecutor _runtimeExecutor; | ||
} | ||
|
||
#pragma mark - Initializer | ||
|
||
- (instancetype)initWithRuntimeExecutor:(facebook::react::RuntimeExecutor)runtimeExecutor | ||
{ | ||
if (self = [super init]) { | ||
_runtimeExecutor = runtimeExecutor; | ||
} | ||
|
||
return self; | ||
} | ||
|
||
#pragma mark - Public API | ||
|
||
- (void)execute:(RCTJSIRuntimeHandlingBlock)block | ||
{ | ||
if (_runtimeExecutor) { | ||
_runtimeExecutor([=](facebook::jsi::Runtime &runtime) { block(runtime); }); | ||
} | ||
} | ||
|
||
@end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters