Skip to content

Commit

Permalink
Unblock template jobs on main due to accidental PRIVATE linking
Browse files Browse the repository at this point in the history
Summary:
I accidentally broke `main` as I added a PRIVATE link for external libraries.
I need to get back to this, but for the meantime I'm disabling this linking
to make the CI green.

Changelog:
[Internal] [Fixed] - Unblock template jobs on main due to accidental PRIVATE linking

Reviewed By: cipolleschi

Differential Revision: D39932205

fbshipit-source-id: 5acbf567e0c194224a01141273665a293ead8e32
  • Loading branch information
cortinico authored and facebook-github-bot committed Sep 30, 2022
1 parent cf98495 commit 3037190
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion ReactAndroid/cmake-utils/ReactNative-application.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -91,5 +91,6 @@ target_link_libraries(ReactAndroid::react_codegen_rncore INTERFACE common_flags)
if(EXISTS ${PROJECT_BUILD_DIR}/generated/rncli/src/main/jni/Android-rncli.cmake)
include(${PROJECT_BUILD_DIR}/generated/rncli/src/main/jni/Android-rncli.cmake)
target_link_libraries(${CMAKE_PROJECT_NAME} ${AUTOLINKED_LIBRARIES})
target_link_libraries(${AUTOLINKED_LIBRARIES} PRIVATE common_flags)
# TODO Re-link autlinking libraries against common_flags
# target_link_libraries(${AUTOLINKED_LIBRARIES} PRIVATE common_flags)
endif()

0 comments on commit 3037190

Please sign in to comment.