TM iOS: Disable in test environment

fkgozali · facebook-github-bot · commit 241091d527ae · 2019-09-04T09:16:32.000-07:00
Summary: For now, disable TM completely in test environment, like RNTester integration/unit tests. See details in T53341772 This also fixes the failure discussed in #26151 Reviewed By: PeteTheHeat Differential Revision: D17147915 fbshipit-source-id: 1c48ebb9c3b81fc08bc33606dcc38c29297d6010
diff --git a/React/Base/RCTBridge.m b/React/Base/RCTBridge.m
@@ -93,6 +93,12 @@ void RCTRegisterModule(Class moduleClass)
 static BOOL turboModuleEnabled = NO;
 BOOL RCTTurboModuleEnabled(void)
 {
+#if RCT_DEBUG
+  // TODO(T53341772): Allow TurboModule for test environment. Right now this breaks RNTester tests if enabled.
+  if (RCTRunningInTestEnvironment()) {
+    return NO;
+  }
+#endif
   return turboModuleEnabled;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -93,6 +93,12 @@ void RCTRegisterModule(Class moduleClass)`
`93`	`93`	`static BOOL turboModuleEnabled = NO;`
`94`	`94`	`BOOL RCTTurboModuleEnabled(void)`
`95`	`95`	`{`
	`96`	`+#if RCT_DEBUG`
	`97`	`+ // TODO(T53341772): Allow TurboModule for test environment. Right now this breaks RNTester tests if enabled.`
	`98`	`+ if (RCTRunningInTestEnvironment()) {`
	`99`	`+ return NO;`
	`100`	`+ }`
	`101`	`+#endif`
`96`	`102`	`return turboModuleEnabled;`
`97`	`103`	`}`
`98`	`104`