Skip to content

Commit 1ce23ce

Browse files
cortinicofacebook-github-bot
authored andcommitted
Fix test-manual-e2e on Android/Hermes for New App Template (#34294)
Summary: The current `test-manual-e2e.sh` script is broken on Android + Hermes + New App Template. This commit fixes it. Specifically: - There is no need to generate Maven Artifacts for RN Tester, as RN Tester consumes them from source. - There is instead a need to generate Maven Artifacts for New App Template, as they need to be included inside the NPM package. - The `:ReactAndroid:hermes-engine:installArchives` task needs to invoked to also generate the Hermes-engine .aar for bundling. ## Changelog [Internal] - Fix test-manual-e2e on Android/Hermes for New App Template Pull Request resolved: #34294 Test Plan: I've tested this against the `0.70-stable` branch and I was able to run an App from the New Template properly. Reviewed By: dmitryrykun Differential Revision: D38239238 Pulled By: cortinico fbshipit-source-id: b3d95bad21515b12a91e29147e70ba8323896660
1 parent 3f50440 commit 1ce23ce

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

scripts/test-manual-e2e.sh

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@ selected_vm=""
3333
PACKAGE_VERSION=""
3434

3535
test_android(){
36-
generate_maven_artifacts
3736
if [ "$1" == "1" ]; then
3837
test_android_hermes
3938
elif [ "$1" == "2" ]; then
@@ -43,7 +42,8 @@ test_android(){
4342

4443
generate_maven_artifacts(){
4544
rm -rf android
46-
./gradlew :ReactAndroid:installArchives || error "Couldn't generate artifacts"
45+
./gradlew :ReactAndroid:installArchives || error "Couldn't generate React Native Maven artifacts"
46+
./gradlew :ReactAndroid:hermes-engine:installArchives || error "Couldn't generate Hermes Engine Maven artifacts"
4747

4848
success "Generated artifacts for Maven"
4949
}
@@ -109,6 +109,10 @@ kill_packagers(){
109109
init_template_app(){
110110
kill_packagers
111111

112+
if [ "$selected_platform" == "1" ]; then
113+
generate_maven_artifacts
114+
fi
115+
112116
PACKAGE_VERSION=$(cat package.json \
113117
| grep version \
114118
| head -1 \

0 commit comments

Comments
 (0)