From 179d5ab8eeb4393737049655876f5853b07f2560 Mon Sep 17 00:00:00 2001 From: Nicola Corti Date: Fri, 28 Apr 2023 04:28:57 -0700 Subject: [PATCH] Do not explicitely depend on androidx.swiperefreshlayout:swiperefreshlayout (#37139) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/37139 This dependency is unnecessary. React Native already exposes a `api` dependency on `androidx.swiperefreshlayout:swiperefreshlayout` so every consumer will also get it. This is just another line in the template we can effectively remove. Changelog: [Android] [Changed] - Do not explicitely depend on androidx.swiperefreshlayout:swiperefreshlayout Reviewed By: cipolleschi Differential Revision: D45390819 fbshipit-source-id: cce34c6a09100d36ee5eb003bb30323f64f0bb9c --- packages/react-native/template/android/app/build.gradle | 9 +++++++-- packages/rn-tester/android/app/build.gradle | 2 -- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/packages/react-native/template/android/app/build.gradle b/packages/react-native/template/android/app/build.gradle index 5b1826b4127e0b..eb8f4efa97a841 100644 --- a/packages/react-native/template/android/app/build.gradle +++ b/packages/react-native/template/android/app/build.gradle @@ -1,3 +1,10 @@ +/* + * Copyright (c) Meta Platforms, Inc. and affiliates. + * + * This source code is licensed under the MIT license found in the + * LICENSE file in the root directory of this source tree. + */ + apply plugin: "com.android.application" apply plugin: "org.jetbrains.kotlin.android" apply plugin: "com.facebook.react" @@ -108,8 +115,6 @@ dependencies { // The version of react-native is set by the React Native Gradle Plugin implementation("com.facebook.react:react-android") - implementation("androidx.swiperefreshlayout:swiperefreshlayout:1.0.0") - debugImplementation("com.facebook.flipper:flipper:${FLIPPER_VERSION}") debugImplementation("com.facebook.flipper:flipper-network-plugin:${FLIPPER_VERSION}") { exclude group:'com.squareup.okhttp3', module:'okhttp' diff --git a/packages/rn-tester/android/app/build.gradle b/packages/rn-tester/android/app/build.gradle index b597120366fa47..eaf8001051208b 100644 --- a/packages/rn-tester/android/app/build.gradle +++ b/packages/rn-tester/android/app/build.gradle @@ -173,8 +173,6 @@ dependencies { // Consume Hermes as built from source only for the Hermes variant. hermesImplementation(project(":packages:react-native:ReactAndroid:hermes-engine")) - implementation "androidx.swiperefreshlayout:swiperefreshlayout:1.0.0" - debugImplementation("com.facebook.flipper:flipper:${FLIPPER_VERSION}") debugImplementation("com.facebook.flipper:flipper-network-plugin:${FLIPPER_VERSION}") debugImplementation("com.facebook.flipper:flipper-fresco-plugin:${FLIPPER_VERSION}")