Skip to content

Commit

Permalink
fix RCTImageLoaderTests
Browse files Browse the repository at this point in the history
Summary:
we couldn't run the RNTesterUnitTests before because these tests didn't respect the nullability specification. after this diff, we can run the tests.

as for the tests.... well 2 are still failing, i'm taking a look at them.

Changelog:
[iOS][Fixed] - fixed RCTImageLoaderTests

Reviewed By: sammy-SC

Differential Revision: D32635689

fbshipit-source-id: d68ae6a3e7f1370d7d76d68c7a6d9812928e6c12
  • Loading branch information
philIip authored and facebook-github-bot committed Nov 24, 2021
1 parent 00ac034 commit 1542f83
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions packages/rn-tester/RNTesterUnitTests/RCTImageLoaderTests.m
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ - (void)testImageLoading
XCTAssertEqual(progress, 1);
XCTAssertEqual(total, 1);
}
partialLoadBlock:nil
partialLoadBlock:^(UIImage *loadedImage) {}
completionBlock:^(NSError *loadError, id loadedImage) {
XCTAssertEqualObjects(loadedImage, image);
XCTAssertNil(loadError);
Expand Down Expand Up @@ -129,7 +129,7 @@ - (void)testImageLoaderUsesImageURLLoaderWithHighestPriority
XCTAssertEqual(progress, 1);
XCTAssertEqual(total, 1);
}
partialLoadBlock:nil
partialLoadBlock:^(UIImage *loadedImage) {}
completionBlock:^(NSError *loadError, id loadedImage) {
XCTAssertEqualObjects(loadedImage, image);
XCTAssertNil(loadError);
Expand Down

0 comments on commit 1542f83

Please sign in to comment.