Skip to content

Commit

Permalink
add link group label to fbios deps
Browse files Browse the repository at this point in the history
Summary:
Currently, fbios link groups depend on supermodules to generate. To continue supporting
link groups while allowing us to migrate off supermodules, we'll add a `fbios_link_group` label on all fbios targets to persist the current hierarchical information.

Reviewed By: jkeljo

Differential Revision: D39543862

fbshipit-source-id: 2abe5b3ee883e77336076d88436a1c84139b5a97
  • Loading branch information
Chenglin Liu authored and facebook-github-bot committed Sep 23, 2022
1 parent 3046ce2 commit 065db68
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 0 deletions.
8 changes: 8 additions & 0 deletions BUCK
Original file line number Diff line number Diff line change
Expand Up @@ -605,6 +605,7 @@ rn_apple_library(
],
inherited_buck_flags = get_static_library_ios_flags(),
labels = [
"fbios_link_group:xplat/default/public.react_native.infra",
"pfh:ReactNative_CommonInfrastructurePlaceholder",
"supermodule:xplat/default/public.react_native.infra",
],
Expand Down Expand Up @@ -830,6 +831,7 @@ rn_apple_library(
"depslint_never_remove", # Some old NativeModule still relies on +load unfortunately.
"disable_plugins_only_validation",
"extension_api_allow_unsafe_unavailable_usages",
"fbios_link_group:xplat/default/public.react_native.infra",
"pfh:ReactNative_CommonInfrastructurePlaceholder",
"supermodule:xplat/default/public.react_native.infra",
],
Expand Down Expand Up @@ -880,6 +882,7 @@ rn_apple_library(
labels = [
"depslint_never_remove", # Some old NativeModule still relies on +load unfortunately.
"disable_plugins_only_validation",
"fbios_link_group:xplat/default/public.react_native.infra",
"pfh:ReactNative_CommonInfrastructurePlaceholder",
"supermodule:xplat/default/public.react_native.infra",
],
Expand Down Expand Up @@ -939,6 +942,7 @@ rn_apple_library(
"depslint_never_remove", # Some old NativeModule still relies on +load unfortunately.
"disable_plugins_only_validation",
"extension_api_allow_unsafe_unavailable_usages",
"fbios_link_group:xplat/default/public.react_native.infra",
"pfh:ReactNative_CommonInfrastructurePlaceholder",
"supermodule:xplat/default/public.react_native.infra",
],
Expand Down Expand Up @@ -987,6 +991,7 @@ rn_apple_library(
"depslint_never_remove", # Some old NativeModule still relies on +load unfortunately.
"disable_plugins_only_validation",
"extension_api_allow_unsafe_unavailable_usages",
"fbios_link_group:xplat/default/public.react_native.infra",
"pfh:ReactNative_CommonInfrastructurePlaceholder",
"supermodule:xplat/default/public.react_native.infra",
],
Expand Down Expand Up @@ -1039,6 +1044,7 @@ rn_apple_library(
"depslint_never_remove", # Some old NativeModule still relies on +load unfortunately.
"disable_plugins_only_validation",
"extension_api_allow_unsafe_unavailable_usages",
"fbios_link_group:xplat/default/public.react_native.infra",
"pfh:ReactNative_CommonInfrastructurePlaceholder",
"supermodule:xplat/default/public.react_native.infra",
],
Expand Down Expand Up @@ -1120,6 +1126,7 @@ rn_apple_library(
"depslint_never_remove", # Some old NativeModule still relies on +load unfortunately.
"disable_plugins_only_validation",
"extension_api_allow_unsafe_unavailable_usages",
"fbios_link_group:xplat/default/public.react_native.infra",
"pfh:ReactNative_CommonInfrastructurePlaceholder",
"supermodule:xplat/default/public.react_native.infra",
],
Expand Down Expand Up @@ -1287,6 +1294,7 @@ rn_apple_library(
labels = [
"depslint_never_remove",
"disable_plugins_only_validation",
"fbios_link_group:xplat/default/public.react_native.infra",
"pfh:ReactNative_CommonInfrastructurePlaceholder",
"supermodule:xplat/default/public.react_native.infra",
],
Expand Down
1 change: 1 addition & 0 deletions Libraries/FBLazyVector/BUCK
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ fb_apple_library(
extension_api_only = True,
frameworks = [],
labels = [
"fbios_link_group:xplat/default/public.react_native.infra",
"pfh:ReactNative_CommonInfrastructurePlaceholder",
"supermodule:xplat/default/public.react_native.infra",
],
Expand Down
1 change: 1 addition & 0 deletions Libraries/RCTRequired/BUCK
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ fb_apple_library(
extension_api_only = True,
frameworks = ["Foundation"],
labels = [
"fbios_link_group:xplat/default/public.react_native.infra",
"pfh:ReactNative_CommonInfrastructurePlaceholder",
"supermodule:xplat/default/public.react_native.infra",
],
Expand Down
1 change: 1 addition & 0 deletions React/CoreModules/BUCK
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ rn_apple_library(
labels = [
"depslint_never_remove", # Some old NativeModule still relies on +load unfortunately.
"disable_plugins_only_validation",
"fbios_link_group:xplat/default/public.react_native.infra",
"pfh:ReactNative_CommonInfrastructurePlaceholder",
"supermodule:xplat/default/public.react_native.infra",
],
Expand Down

0 comments on commit 065db68

Please sign in to comment.