Skip to content

Commit

Permalink
Remove "Early" in Js error reporting function
Browse files Browse the repository at this point in the history
Summary:
We will use this error reporting pipeline for all js errors not only early js errors, so remove all "early" prefixes.

Changelog:
[General][Changed] - Remove "Early" in Js error reporting pipeline

Reviewed By: fkgozali

Differential Revision: D37379339

fbshipit-source-id: d44772818ead977a164c8632c081863851046be6
  • Loading branch information
luluwu2032 authored and facebook-github-bot committed Jun 27, 2022
1 parent 6075d64 commit 0646551
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion React/CoreModules/RCTExceptionsManager.h
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ NS_ASSUME_NONNULL_BEGIN
- (void)reportFatalException:(nullable NSString *)message
stack:(nullable NSArray<NSDictionary *> *)stack
exceptionId:(double)exceptionId;
- (void)reportEarlyJsException:(NSString *)errorMap;
- (void)reportJsException:(NSString *)errorMap;

@property (nonatomic, weak) id<RCTExceptionsManagerDelegate> delegate;

Expand Down
2 changes: 1 addition & 1 deletion React/CoreModules/RCTExceptionsManager.mm
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ - (void)reportFatal:(NSString *)message
}
}

- (void)reportEarlyJsException:(NSString *)errorStr
- (void)reportJsException:(NSString *)errorStr
{
NSData *jsonData = [errorStr dataUsingEncoding:NSUTF8StringEncoding];
NSError *jsonError;
Expand Down

0 comments on commit 0646551

Please sign in to comment.