Skip to content

Commit 04c874b

Browse files
sherginfacebook-github-bot
authored andcommitted
Fabric: Using thread_local keyword instead on own implementation in TransactionTelemetry
Summary: Apparently, there is C++ keyword for this. Changelog: [Internal] Fabric-specific internal change. Reviewed By: sammy-SC Differential Revision: D23754284 fbshipit-source-id: 5f9bbcc72d9c586173624869d614f12d2319fb7b
1 parent 13bc3c8 commit 04c874b

File tree

2 files changed

+4
-5
lines changed

2 files changed

+4
-5
lines changed

ReactCommon/react/renderer/mounting/TransactionTelemetry.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,18 +12,18 @@
1212
namespace facebook {
1313
namespace react {
1414

15-
using ThreadLocalTransactionTelemetry = ThreadStorage<TransactionTelemetry *>;
15+
thread_local TransactionTelemetry *threadLocalTransactionTelemetry = nullptr;
1616

1717
TransactionTelemetry *TransactionTelemetry::threadLocalTelemetry() {
18-
return ThreadLocalTransactionTelemetry::getInstance().get().value_or(nullptr);
18+
return threadLocalTransactionTelemetry;
1919
}
2020

2121
void TransactionTelemetry::setAsThreadLocal() {
22-
ThreadLocalTransactionTelemetry::getInstance().set(this);
22+
threadLocalTransactionTelemetry = this;
2323
}
2424

2525
void TransactionTelemetry::unsetAsThreadLocal() {
26-
ThreadLocalTransactionTelemetry::getInstance().set(nullptr);
26+
threadLocalTransactionTelemetry = nullptr;
2727
}
2828

2929
void TransactionTelemetry::willCommit() {

ReactCommon/react/renderer/mounting/TransactionTelemetry.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111
#include <cstdint>
1212

1313
#include <react/utils/Telemetry.h>
14-
#include <react/utils/ThreadStorage.h>
1514

1615
namespace facebook {
1716
namespace react {

0 commit comments

Comments
 (0)