fix(xcode): backport Xcode 14.3 fix to 71 (#36769)

facebook · Apr 3, 2023 · 0010c38 · 0010c38
1 parent 5162e0b
commit 0010c38
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/scripts/cocoapods/__tests__/codegen_utils-test.rb b/scripts/cocoapods/__tests__/codegen_utils-test.rb
@@ -486,6 +486,14 @@ def test_assertCodegenFolderIsEmpty_whenItIsNotEmpty_itAborts
 
     private
 
+    # mocking the min_ios_version_supported function
+    # as it is not possible to require the original react_native_pod
+    # without incurring in circular deps
+    # TODO: move `min_ios_version_supported` to utils.rb
+    def min_ios_version_supported
+        return '12.4'
+    end
+
     def get_podspec_no_fabric_no_script
         spec = {
           'name' => "React-Codegen",
@@ -498,7 +506,7 @@ def get_podspec_no_fabric_no_script
           'source' => { :git => '' },
           'header_mappings_dir' => './',
           'platforms' => {
-            'ios' => '11.0',
+            'ios' => min_ios_version_supported,
           },
           'source_files' => "**/*.{h,mm,cpp}",
           'pod_target_xcconfig' => { "HEADER_SEARCH_PATHS" =>

diff --git a/scripts/cocoapods/codegen_utils.rb b/scripts/cocoapods/codegen_utils.rb
@@ -85,7 +85,7 @@ def get_react_codegen_spec(package_json_file, folly_version: '2021.07.22.00', fa
           'source' => { :git => '' },
           'header_mappings_dir' => './',
           'platforms' => {
-            'ios' => '11.0',
+            'ios' => min_ios_version_supported,
           },
           'source_files' => "**/*.{h,mm,cpp}",
           'pod_target_xcconfig' => { "HEADER_SEARCH_PATHS" =>