Skip to content

[Fix]Address feedback from #3268 #3312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 9, 2022
Merged

[Fix]Address feedback from #3268 #3312

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions docs/new-architecture-intro.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,9 @@ The guide is divided into five sections:
- [iOS](new-architecture-library-ios)
- **Supporting the New Architecture in your App**
- [Prerequisites for Supporting the New Architecture in your App](new-architecture-app-intro)
- Enabling the New NativeModule System (TurboModule) in your App
- [Android](new-architecture-app-modules-android)
- Enabling the New Renderer (Fabric) in your App
- [Android](new-architecture-app-renderer-android)
- Android
- [Enabling the New NativeModule System (TurboModule) in your App](new-architecture-app-modules-android)
- [Enabling the New Renderer (Fabric) in your App](new-architecture-app-renderer-android)
- [**React 18 & React Native**](react-18-and-react-native)
- [**Troubleshooting**](new-architecture-troubleshooting)
- [**Appendix**](new-architecture-appendix)
1 change: 1 addition & 0 deletions docs/react-18-and-react-native.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,7 @@ On iOS, you'll have access to the `concurrentRootEnabled` method on your `AppDel
/// @return: `true` if the `concurrentRoot` feture is enabled. Otherwise, it returns `false`.
- (BOOL)concurrentRootEnabled
{
// Switch this bool to turn on and off the concurrent root
return true;
}
```
Expand Down
8 changes: 1 addition & 7 deletions website/versioned_docs/version-0.70/new-architecture-app-intro.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,7 @@ This guide is written with the expectation that you’re using the latest React
To update to the most recent version of React Native, you can run this command:

```bash
yarn add react-native@0.70.0
```

Starting from React Native `0.69.0`, you may also need to update the version of React to 18. You can do so by using this command:

```bash
yarn add react@18.0.0
npx react-native upgrade
```

### Android specifics
Expand Down