chore[react-devtools]: cleanup experiment flag and placeholder view (#51)

Author: hoxyq

config/gni/devtools_grd_files.gni

@@ -1460,8 +1460,6 @@ grd_files_debug_sources = [
   "front_end/panels/protocol_monitor/components/toolbar.css.js",
   "front_end/panels/protocol_monitor/protocolMonitor.css.js",
   "front_end/panels/react_devtools/ReactDevToolsModel.js",
-  "front_end/panels/react_devtools/reactDevToolsPlaceholder.css.js",
-  "front_end/panels/react_devtools/ReactDevToolsPlaceholder.js",
   "front_end/panels/react_devtools/ReactDevToolsView.js",
   "front_end/panels/recorder/RecorderController.js",
   "front_end/panels/recorder/RecorderEvents.js",

front_end/core/rn_experiments/experimentsImpl.ts

@@ -178,13 +178,6 @@ Instance.register({
   enabledByDefault: ({ isReactNativeEntryPoint }) => !isReactNativeEntryPoint,
 });
 
-Instance.register({
-  name: RNExperimentName.ENABLE_REACT_DEVTOOLS_PANEL,
-  title: 'Enable React DevTools panel',
-  unstable: true,
-  enabledByDefault: false,
-});
-
 Instance.register({
   name: RNExperimentName.REACT_NATIVE_SPECIFIC_UI,
   title: 'Show React Native-specific UI',

front_end/core/root/Runtime.ts

@@ -272,7 +272,6 @@ export const experiments = new ExperimentsSupport();
 // eslint-disable-next-line rulesdir/const_enum
 export enum RNExperimentName {
   REACT_NATIVE_SPECIFIC_UI = 'react-native-specific-ui',
-  ENABLE_REACT_DEVTOOLS_PANEL = 'enable-react-dev-tools-panel',
   JS_HEAP_PROFILER_ENABLE = 'js-heap-profiler-enable',
   ENABLE_PERFORMANCE_PANEL = 'enable-performance-panel',
 }
@@ -315,7 +314,6 @@ export const enum ExperimentName {
   // React Native-specific experiments - must mirror RNExperimentName above
   JS_HEAP_PROFILER_ENABLE = RNExperimentName.JS_HEAP_PROFILER_ENABLE,
   REACT_NATIVE_SPECIFIC_UI = RNExperimentName.REACT_NATIVE_SPECIFIC_UI,
-  ENABLE_REACT_DEVTOOLS_PANEL = RNExperimentName.ENABLE_REACT_DEVTOOLS_PANEL,
   ENABLE_PERFORMANCE_PANEL = RNExperimentName.ENABLE_PERFORMANCE_PANEL,
 }
 

front_end/entrypoints/rn_fusebox/rn_fusebox.ts

@@ -65,7 +65,6 @@ UI.ViewManager.maybeRemoveViewExtension('throttling-conditions');
 RNExperiments.RNExperimentsImpl.setIsReactNativeEntryPoint(true);
 RNExperiments.RNExperimentsImpl.Instance.enableExperimentsByDefault([
   Root.Runtime.ExperimentName.REACT_NATIVE_SPECIFIC_UI,
-  Root.Runtime.ExperimentName.ENABLE_REACT_DEVTOOLS_PANEL,
 ]);
 
 Host.RNPerfMetrics.registerPerfMetricsGlobalPostMessageHandler();

front_end/panels/react_devtools/BUILD.gn

@@ -8,25 +8,11 @@ import("../../../scripts/build/ninja/devtools_module.gni")
 import("../../../scripts/build/ninja/generate_css.gni")
 import("../visibility.gni")
 
-generate_css("css_files") {
-  sources = [ "reactDevToolsPlaceholder.css" ]
-}
-
-devtools_module("react_devtools_placeholder") {
-  sources = [ "ReactDevToolsPlaceholder.ts" ]
-
-  deps = [
-    ":css_files",
-    "../../core/i18n:bundle",
-    "../../ui/legacy:bundle",
-    "../../ui/lit-html:bundle",
-  ]
-}
-
 devtools_module("react_devtools") {
   sources = [ "ReactDevToolsView.ts", "ReactDevToolsModel.ts" ]
 
   deps = [
+    "../../core/i18n:bundle",
     "../../core/sdk:bundle",
     "../../models/react_native:bundle",
     "../../third_party/react-devtools:bundle",
@@ -38,7 +24,6 @@ devtools_entrypoint("bundle") {
   entrypoint = "react_devtools.ts"
 
   deps = [
-    ":react_devtools_placeholder",
     ":react_devtools",
   ]
 

front_end/panels/react_devtools/ReactDevToolsPlaceholder.ts

@@ -4,7 +4,6 @@
 // found in the LICENSE file.
 
 import * as i18n from '../../core/i18n/i18n.js';
-import * as Root from '../../core/root/root.js';
 import * as UI from '../../ui/legacy/legacy.js';
 
 import type * as ReactDevToolsPanelModule from './react_devtools.js';
@@ -41,14 +40,7 @@ UI.ViewManager.registerViewExtension({
   order: 1000,
   async loadView() {
     const Module = await loadModule();
-
-    if (Root.Runtime.Runtime.isDescriptorEnabled({
-      experiment: Root.Runtime.ExperimentName.ENABLE_REACT_DEVTOOLS_PANEL,
-    })) {
-      return new Module.ReactDevToolsView.ReactDevToolsViewImpl();
-    }
-
-    return Module.ReactDevToolsPlaceholder.ReactDevToolsPlaceholderImpl.instance();
+    return new Module.ReactDevToolsView.ReactDevToolsViewImpl();
   },
 });
 

front_end/panels/react_devtools/reactDevToolsPlaceholder.css

@@ -4,7 +4,6 @@
 // found in the LICENSE file.
 
 import * as ReactDevToolsView from './ReactDevToolsView.js';
-import * as ReactDevToolsPlaceholder from './ReactDevToolsPlaceholder.js';
 import * as ReactDevToolsModel from './ReactDevToolsModel.js';
 
-export {ReactDevToolsView, ReactDevToolsPlaceholder, ReactDevToolsModel};
+export {ReactDevToolsView, ReactDevToolsModel};