Skip to content

Commit fd6562b

Browse files
author
Viswanath Sivakumar
committed
Change http to https, make installation of glog, gflags and double-conversion consistent; use github url for double-conversion
Summary: To fix the error: sudo: apt-get: command not found fetching glog from svn (apt-get fails) svn: E175002: Unable to connect to a repository at URL 'http://google-glog.googlecode.com/svn/trunk' svn: E175002: OPTIONS of 'http://google-glog.googlecode.com/svn/trunk': Could not read status line: connection was closed by server (http://google-glog.googlecode.com) Closes #23 Github Author: NagaChaitanya Vellanki <me@chaitanyavellanki.com> {sync, type="child", parent="github", parentrepo="facebook/proxygen", parentprnum="23", parentprfbid="567899116687621"} Test Plan: Imported from GitHub, without a `Test Plan:` line. Reviewed By: woo@fb.com Subscribers: bmatheny FB internal diff: D1712402 Signature: t1:1712402:1417720645:519ebd9aaea051b0ad529752f1b8b6cea546ab5d
1 parent 8dd956c commit fd6562b

File tree

1 file changed

+13
-14
lines changed

1 file changed

+13
-14
lines changed

proxygen/deps.sh

Lines changed: 13 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -32,9 +32,9 @@ sudo apt-get install -yq \
3232
# deps.sh in fbthrift and folly builds anyways (no trap there)
3333
if ! sudo apt-get install libgoogle-glog-dev;
3434
then
35-
echo "fetching glog from svn (apt-get fails)"
3635
if [ ! -e google-glog ]; then
37-
svn checkout http://google-glog.googlecode.com/svn/trunk/ google-glog
36+
echo "fetching glog from svn (apt-get failed)"
37+
svn checkout https://google-glog.googlecode.com/svn/trunk/ google-glog
3838
cd google-glog
3939
./configure
4040
make
@@ -43,25 +43,24 @@ then
4343
fi
4444
fi
4545

46-
if ! sudo apt-get install libgflags-dev;
46+
if ! sudo apt-get install libgflags-dev;
4747
then
4848
if [ ! -e google-gflags ]; then
49-
echo "Fetching and building libgflags"
50-
wget https://github.com/schuhschuh/gflags/archive/v2.0.tar.gz
51-
mkdir google-gflags
52-
tar xf v2.0.tar.gz -C google-gflags
53-
cd google-gflags/gflags-2.0/
54-
./configure
55-
make
56-
sudo make install
57-
cd ../../
49+
echo "Fetching gflags from svn (apt-get failed)"
50+
svn checkout https://google-gflags.googlecode.com/svn/trunk/ google-gflags
51+
cd google-gflags
52+
./configure
53+
make
54+
sudo make install
55+
cd ..
5856
fi
5957
fi
6058

61-
if ! sudo apt-get install libdouble-conversion-dev;
59+
if ! sudo apt-get install libdouble-conversion-dev;
6260
then
6361
if [ ! -e double-conversion ]; then
64-
git clone https://code.google.com/p/double-conversion double-conversion
62+
echo "Fetching double-conversion from git (apt-get failed)"
63+
git clone https://github.com/floitsch/double-conversion.git double-conversion
6564
cd double-conversion
6665
cmake . -DBUILD_SHARED_LIBS=ON
6766
sudo make install

0 commit comments

Comments
 (0)