Skip to content

Commit 8fae991

Browse files
mzleefacebook-github-bot
authored andcommitted
Remove the somerge configuration
Summary: Special casing this is kind of crazy. We added it to unblock, but now that it has been cleaned up, we should not need it anymore. Reviewed By: IanChilds Differential Revision: D52142498 fbshipit-source-id: e001712642ba429a2cb8723b0dd935a042c68c0b
1 parent 1f7769e commit 8fae991

File tree

1 file changed

+1
-14
lines changed

1 file changed

+1
-14
lines changed

prelude/android/configuration.bzl

Lines changed: 1 addition & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,6 @@ _REFS = {
3232
"default_platform": "config//platform/android:x86_32-fbsource",
3333
"maybe_build_only_native_code": "prelude//android/constraints:maybe_build_only_native_code",
3434
"maybe_building_android_binary": "prelude//os:maybe_building_android_binary",
35-
"maybe_merge_native_libraries": "config//features/android/constraints:maybe_merge_native_libraries",
36-
"merge_native_libraries": "config//features/android/constraints:merge_native_libraries",
3735
"min_sdk_version": "prelude//android/constraints:min_sdk_version",
3836
"x86": "config//cpu/constraints:x86_32",
3937
"x86_64": "config//cpu/constraints:x86_64",
@@ -57,17 +55,13 @@ def _cpu_split_transition_impl(
5755
refs,
5856
cpu_filters,
5957
attrs.min_sdk_version,
60-
attrs.native_library_merge_map,
61-
attrs.native_library_merge_sequence,
6258
)
6359

6460
def _cpu_split_transition(
6561
platform: PlatformInfo,
6662
refs: struct,
6763
cpu_filters: list[str],
68-
min_sdk_version: [int, None],
69-
native_library_merge_map: [dict[str, list[str]], None],
70-
native_library_merge_sequence: [list[list[tuple] | tuple], None]) -> dict[str, PlatformInfo]:
64+
min_sdk_version: [int, None]) -> dict[str, PlatformInfo]:
7165
cpu = refs.cpu
7266
x86 = refs.x86[ConstraintValueInfo]
7367
x86_64 = refs.x86_64[ConstraintValueInfo]
@@ -101,9 +95,6 @@ def _cpu_split_transition(
10195

10296
base_constraints[refs.maybe_building_android_binary[ConstraintSettingInfo].label] = refs.building_android_binary[ConstraintValueInfo]
10397

104-
if native_library_merge_map or native_library_merge_sequence:
105-
base_constraints[refs.maybe_merge_native_libraries[ConstraintSettingInfo].label] = refs.merge_native_libraries[ConstraintValueInfo]
106-
10798
if min_sdk_version:
10899
base_constraints[refs.min_sdk_version[ConstraintSettingInfo].label] = _get_min_sdk_constraint_value(min_sdk_version, refs)
109100

@@ -136,8 +127,6 @@ cpu_split_transition = transition(
136127
attrs = [
137128
"cpu_filters",
138129
"min_sdk_version",
139-
"native_library_merge_map",
140-
"native_library_merge_sequence",
141130
"_is_force_single_cpu",
142131
"_is_force_single_default_cpu",
143132
],
@@ -157,8 +146,6 @@ cpu_transition = transition(
157146
attrs = [
158147
"cpu_filters",
159148
"min_sdk_version",
160-
"native_library_merge_map",
161-
"native_library_merge_sequence",
162149
"_is_force_single_cpu",
163150
"_is_force_single_default_cpu",
164151
],

0 commit comments

Comments
 (0)