-
Notifications
You must be signed in to change notification settings - Fork 626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
compose-source-maps failure after manual changes upgrade 0.70.5 => 0.71.3 (Task :app:createBundleReleaseJsAndAssets or manual scripts) #938
Comments
package.json:
|
Passing over to metro as the error happened during the bundling phase |
Hi @alexkrav - this sounds like it could be #928, related to our switch to Terser as a default minifier. Could you check whether the problem goes away by switching back to the old default - // metro.config.js
module.exports = {
transformer: {
minifierPath: require.resolve('metro-minify-uglify')
// ...
}
// ...
} If so, this fix will be part of RN 0.71.4, and you can safely use |
Hi @robhogan , |
@robhogan ,
still fails with the same mapping error. |
Thanks for trying that - definitely seems like a different issue and one we're unaware of. Would you be able to put up a minimal GitHub repo or steps I can use to reproduce from a new project? I'll have a bit of time tomorrow to try to investigate if so. |
@robhogan What I've found - that if bundle is created with |
I'd like to get to the bottom of this but I'm stuck without a reproduction. On a new project this works: $ npx react-native@latest init RNMetroIssue938 && cd RNMetroIssue938
$ node node_modules/react-native/scripts/compose-source-maps.js ./android/index.android.bundle.packager.map ./android/index.android.bundle.hbc.map -o ./android/index.android.bundle.map
$ ./node_modules/react-native/sdks/hermesc/osx-bin/hermesc -w -O -emit-binary -output-source-map -out=./android/index.android.bundle.hbc ./android/index.android.bundle
$ npx react-native bundle --platform android --dev false --minify false --entry-file index.js --bundle-output ./android/index.android.bundle --sourcemap-output ./android/index.android.bundle.packager.map So, the issue seems to be triggered by something in your project code or the dependencies it imports. If you have time, I'd suggest taking a clone of your project (which I'm guessing you can't share?) and stub / comment / delete big chunks of it until the problem goes away, then work back from there to narrow it down to maybe a bit of code or particular dependency, and then try to reproduce it with just that bit in a new app. |
Chiming in on this issue, not sure if related. I'm on RN 0.66.5 still, recently upgraded from 0.66.4, and this exact issue started happening n my project as well. Bundling with I'm guessing it's a transient dependency that got updated in the meantime that is causing this. We have a massive amount of deps in a monorepo, so it would be extremely difficult to track the culprit down. @alexkrav Do you have any progress on this issue so far? |
@Hless
|
In our case the error msg is as follow, failed to find original info?
|
New Version
0.71.3
Old Version
0.70.5
Build Target(s)
android
Output of
react-native info
System:
OS: macOS 13.2.1
CPU: (16) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
Memory: 4.14 GB / 16.00 GB
Shell: 5.8.1 - /bin/zsh
Binaries:
Node: 18.3.0 - /usr/local/bin/node
Yarn: 1.22.19 - /usr/local/bin/yarn
npm: 8.11.0 - /usr/local/bin/npm
Watchman: 2022.05.30.00 - /usr/local/bin/watchman
Managers:
CocoaPods: 1.11.3 - /Users/alexkrav/.rbenv/shims/pod
SDKs:
iOS SDK:
Platforms: DriverKit 22.2, iOS 16.2, macOS 13.1, tvOS 16.1, watchOS 9.1
Android SDK:
API Levels: 23, 28, 29, 30, 31, 33
Build Tools: 27.0.3, 28.0.3, 29.0.2, 29.0.3, 30.0.2, 30.0.3, 31.0.0, 31.0.0, 33.0.0
System Images: android-27 | Google Play Intel x86 Atom, android-28 | Google APIs Intel x86 Atom, android-29 | Google APIs Intel x86 Atom, android-29 | Google Play Intel x86 Atom, android-30 | Google APIs Intel x86 Atom, android-30 | Google Play Intel x86 Atom, android-31 | Google APIs Intel x86 Atom_64, android-33 | Google APIs Intel x86 Atom_64
Android NDK: 21.4.7075529
IDEs:
Android Studio: 2021.3 AI-213.7172.25.2113.9123335
Xcode: 14.2/14C18 - /usr/bin/xcodebuild
Languages:
Java: 11.0.15 - /usr/bin/javac
npmPackages:
@react-native-community/cli: Not Found
react: 18.2.0 => 18.2.0
react-native: 0.71.3 => 0.71.3
react-native-macos: Not Found
npmGlobalPackages:
react-native: Not Found
Issue and Reproduction Steps
After manual changes using Upgrade Helper android build task
:app:createBundlePreReleaseJsAndAssets
failed on creation of compose mapI could easily to reach the same error just performing create compose map (does not need to build):
The text was updated successfully, but these errors were encountered: