Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Select end if root has no children in focus logic #3254

Merged
merged 1 commit into from
Oct 25, 2022
Merged

Select end if root has no children in focus logic #3254

merged 1 commit into from
Oct 25, 2022

Conversation

thegreatercurve
Copy link
Contributor

@thegreatercurve thegreatercurve commented Oct 25, 2022 •
edited
Loading

It shouldn't matter if the editor is empty when called editor.focus. The cursor should still appear somewhere in the editor when the method is called.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 25, 2022
@vercel
Copy link

vercel bot commented Oct 25, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
lexical ✅ Ready (Inspect) Visit Preview Oct 25, 2022 at 3:56PM (UTC)
lexical-playground ✅ Ready (Inspect) Visit Preview Oct 25, 2022 at 3:56PM (UTC)

@thegreatercurve thegreatercurve marked this pull request as ready for review October 25, 2022 15:52
@thegreatercurve thegreatercurve changed the title Select end if root has no children Select end if root has no children in focus logic Oct 25, 2022
zurfyx
zurfyx approved these changes Oct 25, 2022
View reviewed changes
Copy link
Member

@zurfyx zurfyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm would dare to say this was intentional but I can't recall why..

@thegreatercurve thegreatercurve merged commit 64cc4d3 into main Oct 25, 2022
@thegreatercurve thegreatercurve deleted the bug/focus branch October 25, 2022 20:57
@thegreatercurve
Copy link
Contributor Author

I'm would dare to say this was intentional but I can't recall why..

I looked through the blame history but didn't see anything. I guess we'll see!

@acywatson
Copy link
Contributor

I'm would dare to say this was intentional but I can't recall why..

I looked through the blame history but didn't see anything. I guess we'll see!

I think this is why:

https://github.com/facebook/lexical/actions/runs/3322384417/jobs/5492978426

collab tests on webkit failing starting with this diff.

acywatson added a commit that referenced this pull request Oct 27, 2022
@acywatson
Revert "Select end if root has no children (#3254)"
b3b6ef5 
This reverts commit 64cc4d3.
@acywatson acywatson mentioned this pull request Oct 27, 2022
Merged
acywatson added a commit that referenced this pull request Oct 27, 2022
@acywatson
Revert "Select end if root has no children (#3254)" (#3276)
1a0228e 
This reverts commit 64cc4d3.
thegreatercurve added a commit that referenced this pull request Nov 25, 2022
@thegreatercurve
Select end if root has no children (#3254)
67aaaaa
thegreatercurve pushed a commit that referenced this pull request Nov 25, 2022
@acywatson @thegreatercurve
Revert "Select end if root has no children (#3254)" (#3276)
5f14c87 
This reverts commit 64cc4d3.
@thegreatercurve thegreatercurve mentioned this pull request Nov 25, 2022
Closed
@acywatson acywatson mentioned this pull request Jun 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zurfyx zurfyx zurfyx approved these changes

@trueadm trueadm Awaiting requested review from trueadm

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@tylerjbainbridge tylerjbainbridge Awaiting requested review from tylerjbainbridge

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thegreatercurve @acywatson @zurfyx @facebook-github-bot