Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Figma Embed to Playground #2705

Merged
merged 10 commits into from
Aug 5, 2022
Merged

Add Figma Embed to Playground #2705

merged 10 commits into from
Aug 5, 2022

Conversation

tylerjbainbridge
Copy link
Contributor

@tylerjbainbridge tylerjbainbridge commented Jul 26, 2022

Uses #2704 to add Figma embed functionality.

Because the EmbedConfig handles all of the base URL -> Embed functionality I was able to build this in ~15 minutes.

Screen.Recording.2022-07-25.at.8.24.45.PM.mov

@vercel
Copy link

vercel bot commented Jul 26, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
lexical ✅ Ready (Inspect) Visit Preview Aug 5, 2022 at 3:50PM (UTC)
lexical-playground ✅ Ready (Inspect) Visit Preview Aug 5, 2022 at 3:50PM (UTC)

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 26, 2022
@tylerjbainbridge tylerjbainbridge marked this pull request as ready for review July 26, 2022 00:34
Copy link
Contributor

@thegreatercurve thegreatercurve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just the type errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants