Bug: Pasting over content starting with an empty node appends instead of replace

[orelbn]

Pasting over content that starts with an empty node leads to appending instead of replacement.

Screen.Recording.2024-10-25.at.9.18.08.AM.mov

Lexical version: 0.18.1+dev.esm

Steps To Reproduce

1. go to playground. Press 'Enter'.
2. Type any text or insert any block in the 2nd line
3. Select all, then press paste

The current behavior

Appends to the selected content instead of replacing it on paste

The expected behavior

The text that is selected should replaced not append to.

Impact of fix

Pasting content is pretty fundamental to a text editor. This behaviour can lead to weird behaviours for all users.

[orelbn]

I believe it has to do with this function.

lexical/packages/lexical/src/LexicalSelection.ts

Lines 1334 to 1341 in 409c65e

	/**
	* Attempts to "intelligently" insert an arbitrary list of Lexical nodes into the EditorState at the
	* current Selection according to a set of heuristics that determine how surrounding nodes
	* should be changed, replaced, or moved to accommodate the incoming ones.
	*
	* @param nodes - the nodes to insert
	*/
	insertNodes(nodes: Array<LexicalNode>): void {

I tried to figure it out myself, but the function's assumptions in the third case are unclear to me.

[hunxjunedo]

@trueadm hey, I'd like to contribute to this one. Mind assigning?

[etrepum]

@hunxjunedo there's no need for assignment, when/if you have a solution then you can submit a PR