-
Notifications
You must be signed in to change notification settings - Fork 79
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: facebook/ktfmt
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.48
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: facebook/ktfmt
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.49
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 7 commits
- 11 files changed
- 3 contributors
Commits on Apr 23, 2024
-
Reviewed By: cortinico Differential Revision: D56467598 fbshipit-source-id: 461cf597e828cf15543655febc4e96c88ee67b7d
Configuration menu - View commit details
-
Copy full SHA for 76487c0 - Browse repository at this point
Copy the full SHA 76487c0View commit details -
Stop emitting multiple trailing commas in enum entry lists with multi…
Configuration menu - View commit details
-
Copy full SHA for 4211ac2 - Browse repository at this point
Copy the full SHA 4211ac2View commit details -
Pointing Gradle deps to use latest stable version of ktfmt
Summary: Right now things are broken as is since we don't update snapshot versions of ktfmt to maven. My proposal is to use the latest available stable version when compiling them. Likely not optimal, but at least should reduce the curernt amount of headaches. Issues: ``` FAILURE: Build failed with an exception. * What went wrong: Execution failed for task ':compileKotlin'. > Could not resolve all files for configuration ':compileClasspath'. > Could not find com.facebook:ktfmt:0.49-SNAPSHOT. ``` and ``` FAILURE: Build failed with an exception. * What went wrong: Execution failed for task ':compileJava'. > Could not resolve all files for configuration ':compileClasspath'. > Could not find com.facebook:ktfmt:0.49. ``` Reviewed By: cortinico Differential Revision: D56472377 fbshipit-source-id: 509620821be40353c10e41f72670de5567792915
Configuration menu - View commit details
-
Copy full SHA for 54dfc1a - Browse repository at this point
Copy the full SHA 54dfc1aView commit details
Commits on Apr 24, 2024
-
Add workflow_dispatch to be able to manually retrigger a release.
Summary: 0.48 failed to publish, this should allow us to re-trigger this release. Reviewed By: hick209 Differential Revision: D56474962 fbshipit-source-id: 45440599ccb5e26bacb19b9f6c01f4da5beb0cfe
Configuration menu - View commit details
-
Copy full SHA for b8fbd3c - Browse repository at this point
Copy the full SHA b8fbd3cView commit details -
Summary: By itself this other diff didn't work, {D56474962} https://github.com/facebook/ktfmt/actions/runs/8810035537/job/24181770243#step:5:53 Trying another method now Reviewed By: cortinico Differential Revision: D56512721 fbshipit-source-id: f95bbb91ae316e62b3904f007de7b5e9c2acbd11
Configuration menu - View commit details
-
Copy full SHA for d0b5b8f - Browse repository at this point
Copy the full SHA d0b5b8fView commit details -
Summary: Based on this here https://github.com/kubevirt/hyperconverged-cluster-operator/blob/54462873dd1cb42da28296c5bb3b6dbb8ede37ec/.github/workflows/build-push-images.yaml#L28 Hopefully things work this time. Previous failure => https://github.com/facebook/ktfmt/actions/runs/8820750772/workflow Reviewed By: cortinico Differential Revision: D56528305 fbshipit-source-id: 78cbc46f332e677f56db881f960041528cf76c21
Configuration menu - View commit details
-
Copy full SHA for 24148bb - Browse repository at this point
Copy the full SHA 24148bbView commit details -
Reviewed By: strulovich Differential Revision: D56503355 fbshipit-source-id: 2befbe9ddb60d6284f9dc277e860796bc4a81ed6
1Configuration menu - View commit details
-
Copy full SHA for 0a59f80 - Browse repository at this point
Copy the full SHA 0a59f80View commit details
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v0.48...v0.49