Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: facebook/ktfmt
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.48
Choose a base ref
...
head repository: facebook/ktfmt
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.49
Choose a head ref
  • 7 commits
  • 11 files changed
  • 3 contributors

Commits on Apr 23, 2024

  1. Bump version to 0.49-SNAPSHOT

    Reviewed By: cortinico
    
    Differential Revision: D56467598
    
    fbshipit-source-id: 461cf597e828cf15543655febc4e96c88ee67b7d
    Nivaldo Bondança authored and facebook-github-bot committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    76487c0 View commit details
    Browse the repository at this point in the history
  2. Stop emitting multiple trailing commas in enum entry lists with multi…

    …line items (#458)
    
    Summary: Pull Request resolved: #458
    
    Reviewed By: cortinico
    
    Differential Revision: D56467830
    
    Pulled By: hick209
    
    fbshipit-source-id: 0d97ccb01cfa8436443db27ec244a2759a57251d
    nreid260 authored and facebook-github-bot committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    4211ac2 View commit details
    Browse the repository at this point in the history
  3. Pointing Gradle deps to use latest stable version of ktfmt

    Summary:
    Right now things are broken as is since we don't update snapshot versions of ktfmt to maven.
    
    My proposal is to use the latest available stable version when compiling them.
    Likely not optimal, but at least should reduce the curernt amount of headaches.
    
    Issues:
    ```
    FAILURE: Build failed with an exception.
    
    * What went wrong:
    Execution failed for task ':compileKotlin'.
    > Could not resolve all files for configuration ':compileClasspath'.
       > Could not find com.facebook:ktfmt:0.49-SNAPSHOT.
    ```
    and
    ```
    FAILURE: Build failed with an exception.
    
    * What went wrong:
    Execution failed for task ':compileJava'.
    > Could not resolve all files for configuration ':compileClasspath'.
       > Could not find com.facebook:ktfmt:0.49.
    ```
    
    Reviewed By: cortinico
    
    Differential Revision: D56472377
    
    fbshipit-source-id: 509620821be40353c10e41f72670de5567792915
    Nivaldo Bondança authored and facebook-github-bot committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    54dfc1a View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2024

  1. Add workflow_dispatch to be able to manually retrigger a release.

    Summary: 0.48 failed to publish, this should allow us to re-trigger this release.
    
    Reviewed By: hick209
    
    Differential Revision: D56474962
    
    fbshipit-source-id: 45440599ccb5e26bacb19b9f6c01f4da5beb0cfe
    cortinico authored and facebook-github-bot committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    b8fbd3c View commit details
    Browse the repository at this point in the history
  2. Add params to workflow

    Summary:
    By itself this other diff didn't work, {D56474962}
    https://github.com/facebook/ktfmt/actions/runs/8810035537/job/24181770243#step:5:53
    
    Trying another method now
    
    Reviewed By: cortinico
    
    Differential Revision: D56512721
    
    fbshipit-source-id: f95bbb91ae316e62b3904f007de7b5e9c2acbd11
    Nivaldo Bondança authored and facebook-github-bot committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    d0b5b8f View commit details
    Browse the repository at this point in the history
  3. Fixed param usage

    Summary:
    Based on this here
    https://github.com/kubevirt/hyperconverged-cluster-operator/blob/54462873dd1cb42da28296c5bb3b6dbb8ede37ec/.github/workflows/build-push-images.yaml#L28
    
    Hopefully things work this time.
    
    Previous failure => https://github.com/facebook/ktfmt/actions/runs/8820750772/workflow
    
    Reviewed By: cortinico
    
    Differential Revision: D56528305
    
    fbshipit-source-id: 78cbc46f332e677f56db881f960041528cf76c21
    Nivaldo Bondança authored and facebook-github-bot committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    24148bb View commit details
    Browse the repository at this point in the history
  4. Bump version to 0.49

    Reviewed By: strulovich
    
    Differential Revision: D56503355
    
    fbshipit-source-id: 2befbe9ddb60d6284f9dc277e860796bc4a81ed6
    Nivaldo Bondança authored and facebook-github-bot committed Apr 24, 2024
    1 Configuration menu
    Copy the full SHA
    0a59f80 View commit details
    Browse the repository at this point in the history
Loading