What should be included in v0.7.2

[Huxpro]

This issue is to discuss which fixes should be backported to the next patch release 0.7.2.

EDIT: Since RN 0.64-rc1 has already branched out using 0.7.1, we'll mention this release for RN 0.64 as v0.7.2.

[dulinriley]

I'll have a couple of fixes for the memory profiler that are coming soon. I'd like to get as many of these into v0.7.2 as possible so people on RN 0.64 can use the profiler:

• Fix for multiple native call layers: b7177cb
• Add script ID to heap timeline output: ea2b5aa
• More to come later...

[grabbou]

Just a note that we would prefer the package to be released to CocoaPods repository, just like Flipper is. Is this something you and your team would be able to handle internally? Or do you want me to send a PR to update the CI/release?

[mhorowitz]

Nobody on our team knows anything about how CocoaPods works. According to @alloy, there is no CP repository, it just points to files stored elsewhere. If someone can point to documentation on how this works, it would help a lot. I did some google searching, and did not find any step by step directions. Ideally whatever artifacts are required would be built by CircleCI. If we then need to do some work to publish them to GitHub and update CocoaPods, we can do that, once we learn what to do.

[mhorowitz]

Issue and other crash fixes:
4a0538a
2201966
8cb935c
4108bf9
ba8c4f6
2f07b10
addd6b8
5d08b6e

[alloy]

Nobody on our team knows anything about how CocoaPods works. According to @alloy, there is no CP repository, it just points to files stored elsewhere. If someone can point to documentation on how this works, it would help a lot.

Will respond to this in #368 👍

[dulinriley]

Fix for CVE-2020-1914: b2021df

[janicduplessis]

Fix optional chaining parsing after a function call b61f164

[Huxpro]

• Merged [apple][v0.7] Define the deployment target in the frameworks metadata #428
• Realized memory profiler ones are already patched as part of Memory profiler patches #399
• Cherry-picked all Marc's, the CVE, and the optional chaining bug.
• Bumped version to 0.7.2

Waiting for CI...
OK the CI breaks. Something related to Proxy is not compiled. Marc might forget some intermediate commits here.

[Huxpro]

Turns out we missed 7d3c17f

[Huxpro]

The release has been made on the Github release page. I was able to ensure the rn-tester is working perfectly on Android so the npm packages have also been published.

But I hit some issues with pushing to CocoaPod when I was doing:

env hermes-artifact-url='https://github.com/facebook/hermes/releases/download/v0.7.2/hermes-runtime-darwin-v0.7.2.tar.gz' \ 
pod trunk push hermes-engine.podspec

The verbose output is pasted as a gist.

cc-ed @alloy for help.

Work Required

• Push to CocoaPod.
• Update Hermes version used by RN (see Bump Hermes to 0.7.2 for v0.64 react-native#30561)

[alloy]

@Huxpro Can you try pod trunk push with the --skip-import-validation flag? Related thread CocoaPods/CocoaPods#10065.

[Huxpro]

Great! --skip-import-validation did the trick!

Updating spec repo `trunk`
Validating podspec
/Users/jsx/github/hermes/hermes-engine.podspec:8: warning: already initialized constant Pod::HermesHelper::BUILD_TYPE
/Users/jsx/github/hermes/hermes-engine.podspec:8: warning: previous definition of BUILD_TYPE was here
/Users/jsx/github/hermes/hermes-engine.podspec:8: warning: already initialized constant Pod::HermesHelper::BUILD_TYPE
/Users/jsx/github/hermes/hermes-engine.podspec:8: warning: previous definition of BUILD_TYPE was here
 -> hermes-engine (0.7.2)

Updating spec repo `trunk`

--------------------------------------------------------------------------------
 🎉  Congrats

 🚀  hermes-engine (0.7.2) successfully published
 📅  December 9th, 17:28
 🌎  https://cocoapods.org/pods/hermes-engine
 👍  Tell your friends!
--------------------------------------------------------------------------------

[!] Skipping compilation with `xcodebuild` because target contains no sources.

[Huxpro]

I can verify 0.7.2 is working with USE_HERMES=1 bundle exec pod install --repo-update 🎉

[alloy]

Nice one ✨

[janicduplessis]

Awesome, I just tested it and I can confirm it fixes the optional chaining issue. I just realized I forgot to remove my script to fix the missing min version key in the framework plist so I haven’t tested that yet.