From eabf5fcd25b3eefbfa8af694c72ad78d7a9a48c7 Mon Sep 17 00:00:00 2001 From: Neil Dhar Date: Mon, 4 Apr 2022 15:47:29 -0700 Subject: [PATCH] Always enable debugger by default Summary: We currently enable the debugger by default on all platforms except Android. On Android, we then manually enable the debugger in debug builds. Instead, change it so the debugger is manually disabled in release builds, to simplify the setup. Changelog: [Internal] Reviewed By: jpporto Differential Revision: D35347444 fbshipit-source-id: a97bba0c65c61c211cf9e361e7091343a2c6416f --- CMakeLists.txt | 6 +----- android/hermes/build.gradle | 2 +- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 4971263d75a..0b36f217dd6 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -211,11 +211,7 @@ set(HERMES_USE_STATIC_ICU OFF CACHE BOOL set(HERMES_UNICODE_LITE OFF CACHE BOOL "Enable to use internal no-op unicode functionality instead of relying on underlying system libraries") -set(HERMES_ENABLE_DEBUGGER_DEFAULT OFF) -if (NOT HERMES_IS_MOBILE_BUILD) - set(HERMES_ENABLE_DEBUGGER_DEFAULT ON) -endif() -set(HERMES_ENABLE_DEBUGGER ${HERMES_ENABLE_DEBUGGER_DEFAULT} CACHE BOOL +set(HERMES_ENABLE_DEBUGGER ON CACHE BOOL "Build with debugger support") set(HERMES_ENABLE_IR_INSTRUMENTATION OFF CACHE BOOL diff --git a/android/hermes/build.gradle b/android/hermes/build.gradle index 77d5ff314d1..23aed786a1f 100644 --- a/android/hermes/build.gradle +++ b/android/hermes/build.gradle @@ -47,7 +47,6 @@ android { debug { externalNativeBuild { cmake { - arguments "-DHERMES_ENABLE_DEBUGGER=True" // JS developers aren't VM developers. Give them a faster build. arguments "-DCMAKE_BUILD_TYPE=Release" } @@ -56,6 +55,7 @@ android { release { externalNativeBuild { cmake { + arguments "-DHERMES_ENABLE_DEBUGGER=False" arguments "-DCMAKE_BUILD_TYPE=MinSizeRel" } }