Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Actions] CI - Bump Node JS to v18 in CI Pipeline #4898

Closed

Conversation

Pranav-yadav
Copy link
Contributor

@Pranav-yadav Pranav-yadav commented Jun 29, 2023

Summary

This diff bumps Node JS to v18 in CI Pipeline.
Related PR:

  1. [Breaking] Enforce minimum Node JS to v18 #4897

Changelog

[General] [Changed] - Bump Node JS to v18 in CI Pipeline

Test Plan

  • Should pass tests & builds successfully

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jun 29, 2023
@Pranav-yadav Pranav-yadav changed the title Bump Node JS to v18 in CI Pipeline [Actions] CI - Bump Node JS to v18 in CI Pipeline Jun 29, 2023
@Pranav-yadav
Copy link
Contributor Author

Note
This PR should be merged before #4897 to verify that the tests and builds pass successfully.

Copy link
Member

@passy passy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing. Thank you!

@facebook-github-bot
Copy link
Contributor

@passy has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@passy merged this pull request in 94a2e33.

@Pranav-yadav Pranav-yadav deleted the Pranav-yadav/bump-node18-ci branch July 1, 2023 05:38
facebook-github-bot pushed a commit that referenced this pull request Jul 17, 2023
Summary:
Enforce minimum Node JS version to `v18` via `/package.json#engines
`

- Node JS `v16`'s EOL is `2023-09-11`:
https://nodejs.org/en/blog/announcements/nodejs16-eol

- react-native also bumped Node JS to `v18` recently facebook/react-native#37709 (RN `0.73` will probably enforce min Node JS `v18`)

Bumps in CI via:
1. #4898

## Changelog:

[General] [Breaking] - Enforce minimum Node JS `v18`

Pull Request resolved: #4897

Test Plan: - Should pass tests & builds successfully

Reviewed By: ivanmisuno

Differential Revision: D47294577

Pulled By: passy

fbshipit-source-id: 7ba6a1b6ea6a9e42c77620dc7e0ddf7bd0c641b8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants