Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump OpenSSL-Universal pod dependency to 1.1.171 #1735

Closed
wants to merge 1 commit into from

Conversation

Iskander508
Copy link

@Iskander508 Iskander508 commented Dec 2, 2020

Summary

This should fix the react-native issue with building on Xcode 12: facebook/react-native#29984

Changelog

Upgrade OpenSSL-Universal dependency on the one that includes arm for iPhone Simulator: https://github.com/krzyzanowskim/OpenSSL/releases

Test Plan

This PR is not intended to be merged directly, as more version bumping and propagation through the other pods will be needed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Dec 2, 2020
@coveralls
Copy link

coveralls commented Dec 2, 2020

Pull Request Test Coverage Report for Build 396010412

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 10 unchanged lines in 2 files lost coverage.
  • Overall coverage remained the same at 45.456%

Files with Coverage Reduction New Missed Lines %
desktop/app/src/sandy-chrome/appinspect/LaunchEmulator.tsx 2 60.42%
desktop/app/src/MenuBar.tsx 8 22.58%
Totals Coverage Status
Change from base Build 395881625: 0.0%
Covered Lines: 5550
Relevant Lines: 10887

💛 - Coveralls

@passy
Copy link
Member

passy commented Dec 3, 2020

Thanks!

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@passy has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

brentvatne added a commit to expo/expo that referenced this pull request Dec 3, 2020
brentvatne added a commit to expo/expo that referenced this pull request Dec 3, 2020
@facebook-github-bot
Copy link
Contributor

@passy merged this pull request in 031cec2.

@Iskander508
Copy link
Author

@passy Thank you for integrating this change, but an updated cocoapod needs to be released. The latest (2.3.0) still points to the older version of OpenSSL-Universal (1.0.2.20)

@andreialecu
Copy link

andreialecu commented Dec 12, 2020

I was able to use the updated pod in react-native via:

use_flipper!('Flipper-Folly' => { :podspec => 'https://raw.githubusercontent.com/facebook/flipper/master/iOS/Podspecs/Flipper-Folly.podspec' } )

If you don't use react-native, something like this should work:

pod 'Flipper-Folly', :podspec => 'https://raw.githubusercontent.com/facebook/flipper/master/iOS/Podspecs/Flipper-Folly.podspec'

@andreialecu
Copy link

Seems that this fix doesn't take care of the problem entirely. Running into #1758 now - same problem, but a different pod.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants