Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a new release for the API change in Commit 8dbd09b and make the Podspec point to it. #20

Closed
tirodkar opened this issue Nov 21, 2015 · 4 comments

Comments

@tirodkar
Copy link
Contributor

The merging of PR #18 led to a break in the API. We have made the required changes, however the podspec still points to version 0.1. We use Fishhook rigorously for testing and this change breaks all our pods dependencies. Could we please create a new release for this change and have it added to the podspec (or just have the podspec pointing to head)?

Also, it would be great if we regularly update the podspec with any new releases.

@grp
Copy link
Contributor

grp commented Nov 21, 2015

In general, for Facebook projects I suggest using commit hashes rather than versions — we don't use versions internally and so don't track them closely on CocoaPods.

I'll keep this open to update the published podspec when I get a chance. It'll probably be version 0.2.

@grp grp closed this as completed Nov 21, 2015
@grp grp reopened this Nov 21, 2015
@tirodkar
Copy link
Contributor Author

Thanks. We'll point to HEAD right now instead of the commit so we know if there are any further updates. It would be great if a release is cut if there are any further commits :)

@tirodkar
Copy link
Contributor Author

Hey grp, just checking - are you planning to create a new release soon? Could we get an ETA if possible?

@tirodkar
Copy link
Contributor Author

Closing this thanks to the new 0.2 release update.

@jobsyu jobsyu mentioned this issue Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants