Skip to content

Commit 61911a0

Browse files
Kirill Sazonovfacebook-github-bot
authored andcommitted
Improve readability
Reviewed By: roddym Differential Revision: D38249356 fbshipit-source-id: 557174f5d60b1768d23e82be81f40825e3fb4146
1 parent 6537780 commit 61911a0

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

thrift/lib/cpp2/server/ResourcePool.cpp

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -68,24 +68,24 @@ std::optional<ServerRequestRejection> ResourcePool::accept(
6868
ServerRequest&& request) {
6969
if (requestPile_) {
7070
// This pool is async, enqueue it on the requestPile
71-
auto result = requestPile_->enqueue(std::move(request));
72-
if (result) {
73-
return result;
71+
auto maybeRejection = requestPile_->enqueue(std::move(request));
72+
if (maybeRejection) {
73+
return maybeRejection;
7474
}
7575
concurrencyController_->onEnqueued();
76-
return std::optional<ServerRequestRejection>(std::nullopt);
76+
return {std::nullopt};
7777
} else {
7878
// Trigger processing of request and check for queue timeouts.
7979
if (!request.request()->getShouldStartProcessing()) {
8080
auto eb = detail::ServerRequestHelper::eventBase(request);
8181
HandlerCallbackBase::releaseRequest(
8282
detail::ServerRequestHelper::request(std::move(request)), eb);
83-
return std::optional<ServerRequestRejection>(std::nullopt);
83+
return {std::nullopt};
8484
}
8585

8686
// This pool is sync, just now we execute the request inline.
8787
AsyncProcessorHelper::executeRequest(std::move(request));
88-
return std::optional<ServerRequestRejection>(std::nullopt);
88+
return {std::nullopt};
8989
}
9090
}
9191

0 commit comments

Comments
 (0)