Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Support App Privacy Manifest #2264

Open
3 tasks done
devssun opened this issue Sep 25, 2023 · 40 comments
Open
3 tasks done

Feature Request: Support App Privacy Manifest #2264

devssun opened this issue Sep 25, 2023 · 40 comments

Comments

@devssun
Copy link

devssun commented Sep 25, 2023

Checklist before submitting a feature request

Goals

Apple required App Privacy manifests until 2025. So Facebook SDK that contains an app privacy manifest must be signed.
I would like to know when you adopt this change.

References
https://developer.apple.com/videos/play/wwdc2023/10060/
https://developer.apple.com/news/?id=av1nevon
https://developer.apple.com/app-store/user-privacy-and-data-use/
https://developer.apple.com/support/third-party-SDK-requirements/

Please check it out. Thanks!

Expected results

Add Privacy Manifest

Code samples & details

No response

@LionWY
Copy link

LionWY commented Dec 11, 2023

+1

@allywuyi
Copy link

Apple updated the third-party SDK requirements.

References
https://developer.apple.com/support/third-party-SDK-requirements/

@angelmic
Copy link

+1

1 similar comment
@kelv1nq1an
Copy link

+1

@omarzl
Copy link

omarzl commented Dec 22, 2023

Using a binary analyzer I found these are the "Required reasons API" symbols in the generated frameworks:

Used symbols in binary ./FBAEMKit.framework/FBAEMKit: NSUserDefaults
Used symbols in binary ./FBSDKCoreKit.framework/FBSDKCoreKit: NSFileSystemFreeSize, NSFileSystemSize, NSUserDefaults
Used symbols in binary ./FBSDKCoreKit_Basics.framework/FBSDKCoreKit_Basics: NSUserDefaults

Used symbols in binary ./FBSDKLoginKit.framework/FBSDKLoginKit: no symbols
Used symbols in binary ./FBSDKShareKit.framework/FBSDKShareKit: no symbols
Used symbols in binary ./FBSDKGamingServicesKit.framework/FBSDKGamingServicesKit: no symbols

@kalsariyarahul
Copy link

@maurovc
Copy link

maurovc commented Jan 12, 2024

Hi, are there any updates in terms of ETA we can be aware of as the Spring 2024 deadline comes closer?

Thanks!

@lakshmankreditbee
Copy link

Hi, when can we expect an update regarding this issue?

@asa08
Copy link

asa08 commented Jan 17, 2024

+1

@gtalwadkar
Copy link

Any update on ETA for this changes? Apple Spring 2024 deadline is approaching.

@kalsariyarahul
Copy link

+1

3 similar comments
@BarisSenliol
Copy link

+1

@percival888
Copy link

+1

@cberkeleyHutch
Copy link

+1

@tjmichaeldev
Copy link

tjmichaeldev commented Feb 2, 2024

Punxsutawney Phil has predicted that Spring 2024 will be an early one, given that's Apple's deadline for compliance, is there any chance for an update regarding the status of privacy manifests for this SDK?

@SergeyChereshnyuk
Copy link

Hi Meta tema,

This is important for us too!

Apple has mandated that all third-party SDKs must include a privacy manifest and digital signature starting in spring 2024. We need to know when the new version of Facebook iOS SDK containing these features will be available. Can you let us know the version number and timeline from your end?

Thanks.

@wlxo0401
Copy link

wlxo0401 commented Feb 14, 2024

Apple has mandated that all third-party SDKs must include a privacy manifest and digital signature starting in spring 2024.

@SergeyChereshnyuk
Digital signatures are not required by all third-party libraries.

I understand that the ones on the SDK list listed by Apple are compulsory for digital signatures.

Privacy Manifest is mandatory if you use an API that requires clarification, but I don't know if it's mandatory even if it's not..

Please give me your opinion if I'm wrong.

@extstkim
Copy link

Looks like it made it in via 3183c7e. Just needs to be released

@sylvia-tencent-wmt
Copy link

sylvia-tencent-wmt commented Feb 23, 2024

Dear support team,

When will 3183c7e be released?

Thanks

@a-aasthapoddar
Copy link

+1

@omarzl
Copy link

omarzl commented Mar 1, 2024

The deadlines were published yesterday
https://developer.apple.com/news/?id=3d8a9yyh

@teejayhh
Copy link

teejayhh commented Mar 5, 2024

Looks like it made it in via 3183c7e. Just needs to be released

NSPrivacyCollectedDataTypes is empty in that commit, that doesnt seem right.

@extstkim
Copy link

extstkim commented Mar 5, 2024

Looks like it made it in via 3183c7e. Just needs to be released

NSPrivacyCollectedDataTypes is empty in that commit, that doesnt seem right.

FBSDKCoreKit has it

@teejayhh
Copy link

teejayhh commented Mar 6, 2024

Looks like it made it in via 3183c7e. Just needs to be released

NSPrivacyCollectedDataTypes is empty in that commit, that doesnt seem right.

FBSDKCoreKit has it

Yep I see, til I that you can have multiple privacy manifest files. Sorry for that oversight :)

@saristotelis
Copy link

+1

@andre-alves
Copy link

Still missing privacy manifests for FBSDKLoginKit and FBSDKShareKit...

@extstkim
Copy link

extstkim commented Mar 8, 2024

@ryantobinmeta, @KylinChang Sorry to mention you, but the last two releases have not been git tagged nor published in the Releases page. Is version 17.0.0 out or going through testing? Thanks!

@mammaiap
Copy link

when will be the next release with "Privacy Manifest" feature? .. i am getting the warning from AppStoreConnect . is it possible to get the next release in March 2024?

Thanks & Regards

@samcolak
Copy link

samcolak commented Mar 18, 2024 via email

@phongth7
Copy link

Sorry for mentioning you, @ryantobinmeta, @KylinChang
I've been following this issue for a while and recently discovered that the FBSDKGamingServicesKit doesn't have privacy manifest files.
Is something amiss or not required?

Thanks & Regards

@mikemike396
Copy link

Looks like the PrivacyInfo.xcprivacy files do exist on main.

Commit: af20a84

Would it be possible to get a version bump so we don't have to point to main or a specific commit hash?

@Parvinderjit
Copy link

+1

@devssun
Copy link
Author

devssun commented Mar 28, 2024

Hello
I updated to 17.0.0 but it occurred with error. How can I fix this?
Failed to resolve dependencies Dependencies could not be resolved because no versions of 'facebook-ios-sdk' match the requirement 17.0.0..<18.0.0 and root depends on 'facebook-ios-sdk' 17.0.0..<18.0.0.

@marcoboerner
Copy link

Hello I updated to 17.0.0 but it occurred with error. How can I fix this? Failed to resolve dependencies Dependencies could not be resolved because no versions of 'facebook-ios-sdk' match the requirement 17.0.0..<18.0.0 and root depends on 'facebook-ios-sdk' 17.0.0..<18.0.0.

There is no tag/release for v17.x yet. If you need a version with the new Privacy Manifest, you'd have to use the main branch or a specific commit. See the answer from @mikemike396

@mikemike396
Copy link

🚀 https://github.com/facebook/facebook-ios-sdk/blob/main/CHANGELOG.md#1700 🚀

@extstkim
Copy link

v17 release is out as @mikemike396 pointed out, but does this contain the signing that's required by Apple?

https://developer.apple.com/support/third-party-SDK-requirements/

@angelmic
Copy link

angelmic commented Apr 2, 2024

FBSDKTVOSKit also needed

@ArturoLee
Copy link

NSPrivacyAccessedAPICategorySystemBootTime should be included.

I ran deriveddata % grep -RHn "systemUptime" (https://forums.developer.apple.com/forums/thread/749049) and got:

Binary file ./Setgraph-bfiotivoqdmnksczywmtmehguubu/Index.noindex/Build/Products/Debug-iphoneos/FBSDKCoreKit.framework.dSYM/Contents/Resources/DWARF/FBSDKCoreKit matches
Binary file ./Setgraph-bfiotivoqdmnksczywmtmehguubu/SourcePackages/artifacts/facebook-ios-sdk/FBSDKCoreKit/FBSDKCoreKit.xcframework/ios-arm64_x86_64-simulator/dSYMs/FBSDKCoreKit.framework.dSYM/Contents/Resources/DWARF/FBSDKCoreKit matches
Binary file ./Setgraph-bfiotivoqdmnksczywmtmehguubu/SourcePackages/artifacts/facebook-ios-sdk/FBSDKCoreKit/FBSDKCoreKit.xcframework/ios-arm64_x86_64-maccatalyst/dSYMs/FBSDKCoreKit.framework.dSYM/Contents/Resources/DWARF/FBSDKCoreKit matches
Binary file ./Setgraph-bfiotivoqdmnksczywmtmehguubu/SourcePackages/artifacts/facebook-ios-sdk/FBSDKCoreKit/FBSDKCoreKit.xcframework/ios-arm64/dSYMs/FBSDKCoreKit.framework.dSYM/Contents/Resources/DWARF/FBSDKCoreKit matches
Binary file ./Setgraph-bfiotivoqdmnksczywmtmehguubu/Build/Products/Debug-iphoneos/FBSDKCoreKit.framework.dSYM/Contents/Resources/DWARF/FBSDKCoreKit matches
Binary file ./Setgraph-bfiotivoqdmnksczywmtmehguubu/Build/Products/Debug-iphoneos/Setgraph.app.dSYM/Contents/Resources/DWARF/Setgraph matches

@Sonali2921
Copy link

I am using Facebook core and login in my codebase, which version to use for both of these which includes privacy manifest file? Can anyone help?

@devssun
Copy link
Author

devssun commented Apr 18, 2024

I am using Facebook core and login in my codebase, which version to use for both of these which includes privacy manifest file? Can anyone help?

@Sonali2921 Did you update to 17.0.0 version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests