Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible memory leak in FBRequest? #10

Closed
rkretzschmar opened this issue Aug 22, 2010 · 2 comments
Closed

Possible memory leak in FBRequest? #10

rkretzschmar opened this issue Aug 22, 2010 · 2 comments

Comments

@rkretzschmar
Copy link

When you allocate the NSURLConnection in FBRequest.connect (line 271) - you do the following:
_connection = [[[NSURLConnection alloc] initWithRequest:request delegate:self] retain];

But if you call "alloc" you do not need an extra "retain".

I removed that "retain" and it still works.

@yujuan
Copy link

yujuan commented Aug 23, 2010

This is a very good point. Will address in the next fix.

Thanks!

@yujuan
Copy link

yujuan commented Aug 25, 2010

just updated, thanks for your comment

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants