Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: facebook/facebook-ios-sdk
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v9.0.0
Choose a base ref
...
head repository: facebook/facebook-ios-sdk
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v9.0.1
Choose a head ref
  • 19 commits
  • 70 files changed
  • 6 contributors

Commits on Jan 19, 2021

  1. Fix changelog blog post link

    Summary: title
    
    Reviewed By: KylinChang
    
    Differential Revision: D25958403
    
    fbshipit-source-id: 2de0e4f2a0cb80cbf93b09109c720c8a8f02c873
    ppansy authored and facebook-github-bot committed Jan 19, 2021
    Configuration menu
    Copy the full SHA
    39b1f93 View commit details
    Browse the repository at this point in the history
  2. Fix FacebookSDK.podspec for xcframework

    Summary:
    1. tag should not be used when using `:http` for source
    2. zip file should be with suffix `.xcframework.zip`
    
    Reviewed By: KylinChang
    
    Differential Revision: D25960788
    
    fbshipit-source-id: 2436d3842264018c252d3d7e4b9b1c0561fa040e
    dreamolight authored and facebook-github-bot committed Jan 19, 2021
    Configuration menu
    Copy the full SHA
    7d98ba6 View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2021

  1. Implement copy for AuthenticationToken

    Summary: title
    
    Reviewed By: patters
    
    Differential Revision: D25980203
    
    fbshipit-source-id: 11dfa4d5b1c623218b7a0b20c0d4ecc7e0cfab2d
    ppansy authored and facebook-github-bot committed Jan 20, 2021
    Configuration menu
    Copy the full SHA
    0db7d7e View commit details
    Browse the repository at this point in the history

Commits on Jan 21, 2021

  1. Sync ATE for app launch

    Summary: $title
    
    Reviewed By: dreamolight
    
    Differential Revision: D25953038
    
    fbshipit-source-id: 934f619bf7aeccaebd5f8b7abf20cea0e506bd7e
    KylinChang authored and facebook-github-bot committed Jan 21, 2021
    Configuration menu
    Copy the full SHA
    0403812 View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2021

  1. Fix FBSDKLoginButton nonce property attributes (#1616)

    Summary:
    Thanks for proposing a pull request!
    
    To help us review the request, please complete the following:
    
    - [x] sign [contributor license agreement](https://developers.facebook.com/opensource/cla)
    - [x] I've ensured that all existing tests pass and added tests (when/where necessary)
    - [x] I've updated the documentation (when/where necessary) and [Changelog](CHANGELOG.md) (when/where necessary)
    - [x] I've added the proper label to this pull request (e.g. `bug` for bug fixes)
    
    ## Pull Request Details
    
    The attributes for the `nonce` property of the `FBSDKLoginButton` are incorrect and lead to build errors.
    
    In scenarios where the [`objc-property-assign-on-object-type`](https://clang.llvm.org/docs/DiagnosticsReference.html#wobjc-property-assign-on-object-type) flag is enabled and warnings are treated as errors, the build fails with: `FBSDKLoginKit.framework/Headers/FBSDKLoginButton.h:109:1: 'assign' property of object type may become a dangling reference; consider using 'unsafe_unretained'`
    
    Pull Request resolved: #1616
    
    Reviewed By: jingping2015
    
    Differential Revision: D26002203
    
    Pulled By: ppansy
    
    fbshipit-source-id: 5101f92f8f79b069f63b022129f70ad7becdb4e3
    kmcbride authored and facebook-github-bot committed Jan 22, 2021
    Configuration menu
    Copy the full SHA
    9ce4507 View commit details
    Browse the repository at this point in the history
  2. Update FacebookSDK.podspec to use FBSDKCoreKit instead of xcframework…

    … to avoid conflicts between AN and FB SDK
    
    Summary: As title
    
    Reviewed By: KylinChang
    
    Differential Revision: D26010231
    
    fbshipit-source-id: be9d72210a10fbe5022926c710074e46d9331a16
    dreamolight authored and facebook-github-bot committed Jan 22, 2021
    Configuration menu
    Copy the full SHA
    7cf84bb View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2021

  1. Remove gatekeepers loading in server configuration

    Summary: Remove loading gatekeepers in server configuration to avoid potential deadlock issue
    
    Reviewed By: dreamolight
    
    Differential Revision: D25960980
    
    fbshipit-source-id: e95846fd0acfe3048c4c8a40b02253ec6cb431d7
    KylinChang authored and facebook-github-bot committed Jan 25, 2021
    Configuration menu
    Copy the full SHA
    07a0e95 View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2021

  1. Add dispatch_once when enabling AAM/Codeless

    Summary: We can dispatch only once when enabling AAM/Codeless since the enable functions are called under the completion block of loadServerConfiguration and SDK can always get the latest config before enabling them.
    
    Reviewed By: dreamolight
    
    Differential Revision: D26056157
    
    fbshipit-source-id: 7e2332bc04c801cb19625e522a65f3815dc227cb
    KylinChang authored and facebook-github-bot committed Jan 26, 2021
    Configuration menu
    Copy the full SHA
    1990e62 View commit details
    Browse the repository at this point in the history
  2. FBSDKWebViewAppLinkResolver bug (#1597)

    Summary:
    Thanks for proposing a pull request!
    
    To help us review the request, please complete the following:
    
    - [x] sign [contributor license agreement](https://developers.facebook.com/opensource/cla)
    - [x] I've ensured that all existing tests pass and added tests (when/where necessary)
    - [x] I've updated the documentation (when/where necessary) and [Changelog](CHANGELOG.md) (when/where necessary)
    - [x] I've added the proper label to this pull request (e.g. `bug` for bug fixes)
    
    ## Pull Request Details
    
    It should solve this crash
    
    #1596 (comment)
    
    Pull Request resolved: #1597
    
    Test Plan: **Add your test plan here**
    
    Reviewed By: jingping2015
    
    Differential Revision: D25589734
    
    Pulled By: joesus
    
    fbshipit-source-id: 5d54caaf2d3eb3a63510fa28a3077416cd662f39
    Kry256 authored and facebook-github-bot committed Jan 26, 2021
    Configuration menu
    Copy the full SHA
    fdedf3b View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2021

  1. fix crash on FBSDKWebViewAppLinkResolverWebViewDelegate (#1624)

    Summary:
    Thanks for proposing a pull request!
    
    To help us review the request, please complete the following:
    
    - [x] sign [contributor license agreement](https://developers.facebook.com/opensource/cla)
    - [x] I've ensured that all existing tests pass and added tests (when/where necessary)
    - [x] I've updated the documentation (when/where necessary) and [Changelog](CHANGELOG.md) (when/where necessary)
    - [x] I've added the proper label to this pull request (e.g. `bug` for bug fixes)
    
    ## Pull Request Details
    
    It should solve this crash
    
    #1596 (comment)
    
    Pull Request resolved: #1624
    
    Reviewed By: dreamolight
    
    Differential Revision: D26103826
    
    Pulled By: joesus
    
    fbshipit-source-id: 3589b6b610b65e9a14506e15980aca1a8f93bd85
    Kry256 authored and facebook-github-bot committed Jan 28, 2021
    Configuration menu
    Copy the full SHA
    82ebe1f View commit details
    Browse the repository at this point in the history
  2. Guidance around aggregate pod conflicts

    Summary: Updating Changelog to provide guidance around library conflicts with CocoaPods that do not depend on XCFrameworks.
    
    Reviewed By: jingping2015
    
    Differential Revision: D26134533
    
    fbshipit-source-id: 2b5fec173efdecbead67a01e750b61e14cdcd761
    joesus authored and facebook-github-bot committed Jan 28, 2021
    Configuration menu
    Copy the full SHA
    b92b76b View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2021

  1. Remove Monitoring Feature (#1625)

    Summary:
    Pull Request resolved: #1625
    
    I don't see this feature being launched anytime soon and it's easy to re-add if we do decide to pursue this.
    
    Reviewed By: jingping2015
    
    Differential Revision: D26134853
    
    fbshipit-source-id: 78f0c40eca97b0fbd78ab6130d742bc3ce9a982d
    joesus authored and facebook-github-bot committed Jan 29, 2021
    Configuration menu
    Copy the full SHA
    4350614 View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2021

  1. make config and nonce getter accessible to internal modules

    Reviewed By: joesus
    
    Differential Revision: D26090971
    
    fbshipit-source-id: 5e0e78c48004a7a2b95e065b6b29c1d3e5d377a3
    ppansy authored and facebook-github-bot committed Jan 30, 2021
    Configuration menu
    Copy the full SHA
    cc0cdb7 View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2021

  1. Add key/APIs to enable/disable SKAdNetwork Report

    Summary:
    1. Add enable control support for the key FacebookSKAdNetworkReportEnabled in info.plist
    2. Add APIs to control SKAdNetwork Report
    
    Reviewed By: dreamolight
    
    Differential Revision: D26131646
    
    fbshipit-source-id: 4cd15c3529251bc62af33bc2d7e7018f522e7842
    KylinChang authored and facebook-github-bot committed Feb 1, 2021
    Configuration menu
    Copy the full SHA
    bfdb8a6 View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2021

  1. Fix CoreKitBasics Static Build (#1634)

    Summary:
    Pull Request resolved: #1634
    
    The statically linked binary for FBSDKCoreKit/Basics is built based on an Xcode scheme `FBSDKCoreKit_Basics`. The headers in that scheme were not marked as publicly visible.
    
    Reviewed By: sharoni
    
    Differential Revision: D26225603
    
    fbshipit-source-id: a54d7c5a6f99c07f054d200716a8d711103884c1
    joesus authored and KylinChang committed Feb 8, 2021
    Configuration menu
    Copy the full SHA
    eaaeec2 View commit details
    Browse the repository at this point in the history
  2. Linter warning fix for missing import

    Summary: $title
    
    Reviewed By: Mxiim
    
    Differential Revision: D26227395
    
    fbshipit-source-id: 3b8849f5fa03593cee8eeeb8643843e44619a282
    joesus authored and KylinChang committed Feb 8, 2021
    Configuration menu
    Copy the full SHA
    84c6c89 View commit details
    Browse the repository at this point in the history
  3. Fix Swift Package Manager error for Xcode 12.5 (#1635)

    Summary:
    Pull Request resolved: #1635
    
    12.5 Beta errors on loading a package with nested 'include' directories. At one point we needed this in order to access internal headers from CoreKit.
    
    Checked this fix with Xcode 12.5_Beta, Xcode 11.2, and Xcode 11.7 so either that workaround was never needed or it was needed before 11.2 and was fixed.
    
    Given the age of the software and the likelihood of Apple dropping support for Xcode 11 in the near future, there is little incentive to come up with a workaround for supporting below 11.2.
    
    Reviewed By: Mxiim
    
    Differential Revision: D26227309
    
    fbshipit-source-id: e9f15599152c413891b03632d20479b948791642
    joesus authored and KylinChang committed Feb 8, 2021
    Configuration menu
    Copy the full SHA
    22468f3 View commit details
    Browse the repository at this point in the history
  4. Prevent AppEvents ActivateApp Deadlock

    Summary:
    This is the fix for #1636
    
    Added some messaging to help explain the error and the fix.
    
    Reviewed By: KylinChang
    
    Differential Revision: D26261477
    
    fbshipit-source-id: fe2f39baec2b26f5c89f8c9181b6b69f4e07b7ac
    joesus authored and KylinChang committed Feb 8, 2021
    Configuration menu
    Copy the full SHA
    5a4a419 View commit details
    Browse the repository at this point in the history
  5. Bump version 9.0.1

    Summary: As title
    
    Reviewed By: joesus
    
    Differential Revision: D26215176
    
    fbshipit-source-id: 19c0291c6cdb2fa678d90d852be8015501284b63
    KylinChang committed Feb 8, 2021
    Configuration menu
    Copy the full SHA
    ad85021 View commit details
    Browse the repository at this point in the history
Loading