Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: facebook/facebook-ios-sdk
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v5.0.0
Choose a base ref
...
head repository: facebook/facebook-ios-sdk
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v5.0.1
Choose a head ref
  • 20 commits
  • 55 files changed
  • 9 contributors

Commits on May 1, 2019

  1. format FBSDKCoreKit.podspec

    Summary: as title
    
    Reviewed By: dreamolight
    
    Differential Revision: D15162842
    
    fbshipit-source-id: 6a5fb4333f925105aa8d4771fbd1820018ec0e07
    tianqibt authored and facebook-github-bot committed May 1, 2019
    Configuration menu
    Copy the full SHA
    ee53475 View commit details
    Browse the repository at this point in the history

Commits on May 2, 2019

  1. Updated Podspecs

    Summary: Opted for more optimistic indicators for deps
    
    Reviewed By: joesus
    
    Differential Revision: D15152998
    
    fbshipit-source-id: d21451671e2b0e115f21d87588e4096360a770d1
    Cody Winton authored and facebook-github-bot committed May 2, 2019
    Configuration menu
    Copy the full SHA
    0257417 View commit details
    Browse the repository at this point in the history
  2. Initialize SDK when set AutoInitEnabled to YES

    Summary: Similar to D15178951 for android.
    
    Reviewed By: wi3lau
    
    Differential Revision: D15178990
    
    fbshipit-source-id: 10a65095e68e56f191aefd2a008beb2a01547f0c
    dreamolight authored and facebook-github-bot committed May 2, 2019
    Configuration menu
    Copy the full SHA
    fd75746 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2019

  1. Update the FBSDKCoreKit podspec to take into account the new modulema…

    …p file (#988)
    
    Summary:
    With the introduction of the `FBSDKCoreKit.modulemap` to the Basics folder, after updating to the newer version of the pod, I keep getting the following warning:
    <img width="470" alt="Screen Shot 2019-05-01 at 5 51 06 pm" src="https://user-images.githubusercontent.com/4775087/57009482-384d3e00-6c3a-11e9-95cb-80ed1ed3e795.png">
    As it is not a source file, Xcode doesn't need to analyse because it won't be able to compile it.
    
    - Restricted the type of source files to `.h` and `.m`
    
    Thanks for proposing a pull request.
    
    To help us review the request, please complete the following:
    
    - [x] sign [contributor license agreement](https://developers.facebook.com/opensource/cla)
    - [x] describe the change (for example, what happens before the change, and after the change)
    Pull Request resolved: #988
    
    Reviewed By: codytwinton
    
    Differential Revision: D15205123
    
    Pulled By: tianqibt
    
    fbshipit-source-id: 1fbfff432e25a7906589be7f209200f48b3f1601
    afonsograca authored and facebook-github-bot committed May 3, 2019
    Configuration menu
    Copy the full SHA
    e299c1a View commit details
    Browse the repository at this point in the history

Commits on May 7, 2019

  1. migrate util functions to Basics

    Summary: As part of the FB & AN SDK Consolidation work, this diff is to migrate util function to Basics
    
    Reviewed By: KylinChang
    
    Differential Revision: D15216479
    
    fbshipit-source-id: 4cdf623948e39526f8d9a13157bc8e55cd616b16
    tianqibt authored and facebook-github-bot committed May 7, 2019
    Configuration menu
    Copy the full SHA
    6d0b5aa View commit details
    Browse the repository at this point in the history
  2. add back unit test for JSON string

    Summary: In D15005995, test for JSON string was removed, because we need to migrate util functions to Basics. This diff is to add this unit test back.
    
    Reviewed By: KylinChang
    
    Differential Revision: D15216498
    
    fbshipit-source-id: b9b199bec20549b973d9469c5fcf7b5ec1dc365d
    tianqibt authored and facebook-github-bot committed May 7, 2019
    Configuration menu
    Copy the full SHA
    ed024a1 View commit details
    Browse the repository at this point in the history
  3. migrate util functions to Basics module

    Summary: as title
    
    Reviewed By: dreamolight
    
    Differential Revision: D15216579
    
    fbshipit-source-id: f9b6b9be0dd45872cbfdc93ddd37c3220f3269f7
    tianqibt authored and facebook-github-bot committed May 7, 2019
    Configuration menu
    Copy the full SHA
    ee641fe View commit details
    Browse the repository at this point in the history

Commits on May 8, 2019

  1. migrate util functions to Basics module

    Summary: as title
    
    Reviewed By: YOUDAN
    
    Differential Revision: D15248745
    
    fbshipit-source-id: fc5e154855eeaf04e0452a9c6f86533c1c4d3419
    tianqibt authored and facebook-github-bot committed May 8, 2019
    Configuration menu
    Copy the full SHA
    9147cb9 View commit details
    Browse the repository at this point in the history
  2. Remove Deprecated Properties/Methods

    Summary:
    Removed methods/properties that were deprecated in 4.X and slated for removal in v5.0
    
    Since this was included in Changelog for `v5.0.0`, it is proposed that this go out as `v5.0.1`.
    
    Reviewed By: jingping2015
    
    Differential Revision: D15209838
    
    fbshipit-source-id: 83b772a24027389ec98090886ab3e5035f674dee
    Cody Winton authored and facebook-github-bot committed May 8, 2019
    Configuration menu
    Copy the full SHA
    2c4c8bd View commit details
    Browse the repository at this point in the history

Commits on May 10, 2019

  1. Use FBSDKLogger instead of NSLog

    Summary: Update some uses of NSLog to FBSDKLogger, so it's possible to disable them if desired.
    
    Reviewed By: codytwinton
    
    Differential Revision: D15297652
    
    fbshipit-source-id: 700610c8679f3bd68357be168e937bd3a4331e05
    robtimp authored and facebook-github-bot committed May 10, 2019
    1 Configuration menu
    Copy the full SHA
    3b92aeb View commit details
    Browse the repository at this point in the history

Commits on May 14, 2019

  1. Add KillSwtich unit tests for iOS SDK

    Summary: Add KillSwtich unit tests for iOS SDK
    
    Reviewed By: tianqibt
    
    Differential Revision: D15325744
    
    fbshipit-source-id: 78ea8f5eaf4fc5e98377ceac27bd0f074dd93cd7
    KylinChang authored and facebook-github-bot committed May 14, 2019
    Configuration menu
    Copy the full SHA
    7d45dd6 View commit details
    Browse the repository at this point in the history

Commits on May 16, 2019

  1. Change Xcode version to 10.1 for github release

    Summary:
    There is bitcode version change introduced by Xcode 10.2, so the frameworks we generated via Xcode 10.2 won't be able to be used in Xcode 10.1.
    
    To support manual integration with Xcode 10.1, we need to build the frameworks with Xcode 10.1.
    
    FYI: frameworks built via Xcode 10.2 could be used in newer version of Xcode (e.g. Xcode 10.2)
    
    Reviewed By: codytwinton
    
    Differential Revision: D15351874
    
    fbshipit-source-id: 97f9f6babd2b1a4b5b1e634dd1f49e4b9d837321
    dreamolight authored and facebook-github-bot committed May 16, 2019
    Configuration menu
    Copy the full SHA
    fb1d6f2 View commit details
    Browse the repository at this point in the history
  2. graph request is fired when activate app

    Summary: as title
    
    Reviewed By: KylinChang
    
    Differential Revision: D15226590
    
    fbshipit-source-id: a84d6cddc6b01e2568cfda8fccd6e8cc628b74e7
    tianqibt authored and facebook-github-bot committed May 16, 2019
    Configuration menu
    Copy the full SHA
    5996f6c View commit details
    Browse the repository at this point in the history

Commits on May 17, 2019

  1. Exchange nonce for token

    Summary:
    Instead of returning an `access_token` directly, a `nonce` will be returned in the future (`nonce` is added to possible response types).
    
    When the `nonce` parameter is found in the URL that reopens the app, the SDK will make a call to `graph.api.facebook.com/oauth/access_token` with a new grant type of `fb_exchange_nonce`, and the access token will then be returned to the SDK.
    
    Reviewed By: dreamolight
    
    Differential Revision: D15289613
    
    fbshipit-source-id: 7b6f531dcee6314d85814ebfa329a074b16f489b
    robtimp authored and facebook-github-bot committed May 17, 2019
    Configuration menu
    Copy the full SHA
    6f54918 View commit details
    Browse the repository at this point in the history

Commits on May 20, 2019

  1. add timeout for request stub

    Summary: as title
    
    Reviewed By: codytwinton
    
    Differential Revision: D15381634
    
    fbshipit-source-id: 2cc265a63601d54282f45ec93aae6d3dd30087c7
    tianqibt authored and facebook-github-bot committed May 20, 2019
    Configuration menu
    Copy the full SHA
    ce48979 View commit details
    Browse the repository at this point in the history
  2. graph request is fired when update user properties

    Summary: as title
    
    Reviewed By: codytwinton, KylinChang
    
    Differential Revision: D15350580
    
    fbshipit-source-id: 1104d359bba416a6686b40a6d07985872155fd6e
    tianqibt authored and facebook-github-bot committed May 20, 2019
    Configuration menu
    Copy the full SHA
    8de91df View commit details
    Browse the repository at this point in the history
  3. Add Unit test FBSDKApplicationDelegate

    Summary: Unit test checks if FBSDKAppEvents becomes active
    
    Reviewed By: tianqibt
    
    Differential Revision: D15379668
    
    fbshipit-source-id: f9e41506a9e449ef544d487ac2c95d71d6da5ed9
    Steven Gschwind authored and facebook-github-bot committed May 20, 2019
    Configuration menu
    Copy the full SHA
    11947ad View commit details
    Browse the repository at this point in the history
  4. to OCMReject() instead of [[mockObject reject] methodToBeCalled]

    Summary: Reformatting OCMReject call to be consistent across tests
    
    Reviewed By: tianqibt
    
    Differential Revision: D15385737
    
    fbshipit-source-id: b174e3f4974d9a78ee524bf78c029f2769c74e92
    Steven Gschwind authored and facebook-github-bot committed May 20, 2019
    Configuration menu
    Copy the full SHA
    a94d769 View commit details
    Browse the repository at this point in the history

Commits on May 21, 2019

  1. Update Carthage to create a single archive (#990)

    Summary:
    Carthage expects a single .zip file containing all frameworks for all platforms. The current method means that only the FBSDKCoreKit framework will be downloaded (when not using `--no-use-binaries`), this should allow them to all be downloaded automatically by Carthage.
    
     ---
    
    Thanks for proposing a pull request.
    
    To help us review the request, please complete the following:
    
    - [x] sign [contributor license agreement](https://developers.facebook.com/opensource/cla)
    - [x] describe the change (for example, what happens before the change, and after the change)
    Pull Request resolved: #990
    
    Reviewed By: tianqibt
    
    Differential Revision: D15408957
    
    Pulled By: dreamolight
    
    fbshipit-source-id: 209e03c15c4e74e974e5ba7a96eacbb4c593ccab
    JosephDuffy authored and facebook-github-bot committed May 21, 2019
    Configuration menu
    Copy the full SHA
    ec3a763 View commit details
    Browse the repository at this point in the history

Commits on May 22, 2019

  1. Bump IOS SDK version to 5.0.1

    Summary: version bump
    
    Reviewed By: stoyan
    
    Differential Revision: D15445451
    
    fbshipit-source-id: 787695a71a936509300a5a2783ace02fec9beb17
    jingping2015 authored and facebook-github-bot committed May 22, 2019
    Configuration menu
    Copy the full SHA
    1bfc8fe View commit details
    Browse the repository at this point in the history
Loading