Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: facebook/facebook-ios-sdk
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v12.0.0
Choose a base ref
...
head repository: facebook/facebook-ios-sdk
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v12.0.1
Choose a head ref
  • 3 commits
  • 19 files changed
  • 2 contributors

Commits on Oct 15, 2021

  1. ShareDialog initialization bug 

    Summary: Share dialog custom initializer was calling `[super init]` instead of `[self init]` so it was bypassing the overridden initializer that sets dependencies.

Reviewed By: jawwad

Differential Revision: D31688271

fbshipit-source-id: 4f50a33403f7e001ad6cd353a39588be59086757
    @joesus @facebook-github-bot
    joesus authored and facebook-github-bot committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    da904be View commit details
    Browse the repository at this point in the history

  2. Bump SDK version to 12.0.1 

    Summary:
Version bump for 12.0.1 to release a fix for Share Dialog not presenting for SDK 12.0.0

#1909

Updated changelog

Reviewed By: samodom

Differential Revision: D31688308

fbshipit-source-id: d890296b2f1b70d9ba5ee138c14e358e82639648
    @jawwad @facebook-github-bot
    jawwad authored and facebook-github-bot committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    5c28a54 View commit details
    Browse the repository at this point in the history

  3. Update Package.swift and podspecs with new checksums and sha1s for v1… 

    …2.0.1

Summary:
I ran this on the release branch: remote/fbobjc/releases/release-ios-sdk-v12.0.1
```
swift run runner prepare-release | xcpretty
```

This diff was created on the release branch but I'm going to rebase it on master so that it can be merged into master. (It needs to be in master in case someone points their SPM to master, that way they still get the latest release).

After its merged into master, I will pick it into the release branch.

Reviewed By: samodom

Differential Revision: D31696499

fbshipit-source-id: 2a0880489e10fb8457edbfd021be227a546ee859
    @jawwad @facebook-github-bot
    jawwad authored and facebook-github-bot committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    0571621 View commit details
    Browse the repository at this point in the history
Loading