Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: mdx-loader caching issue => linked md files should be added as dependencies #5757

Open
slorber opened this issue Oct 21, 2021 · 3 comments
Open

Bug: mdx-loader caching issue => linked md files should be added as dependencies #5757

slorber opened this issue Oct 21, 2021 · 3 comments
Labels
bug An error in the Docusaurus core causing instability or issues with its execution difficulty: intermediate Issues that are medium difficulty level, e.g. moderate refactoring with a clear test plan. domain: markdown Related to Markdown parsing or syntax status: blocked This issue is blocked by another issue or external dep and can't be pushed further.

Comments

@slorber
Copy link
Collaborator

slorber commented Oct 21, 2021 •
edited
Loading

🐛 Bug Report

Suppose you have:

# md file

[link](./otherMdFile.md)

Then if the linked md file change from slug: /path1 to slug: /path2 the md file must be "invalidated"

Otherwise, we'll keep linking to /path1 (instead of new /path2) due to Webpack caches.

mdx-loader probably needs to collect linked file paths, and call this.addDependency(linkedFilePath);

Issue noticed in PR #5755

https://app.netlify.com/sites/docusaurus-2/deploys/6171611d255a130008c35dff

Had to clear the Netlify cache to fix the build failure
@slorber slorber added the bug An error in the Docusaurus core causing instability or issues with its execution label Oct 21, 2021
@armano2 armano2 mentioned this issue Nov 16, 2021
Closed
2 tasks
@Josh-Cena Josh-Cena added the difficulty: advanced Issues that are complex, e.g. large scoping for long-term maintainability. label Dec 15, 2021
@Josh-Cena Josh-Cena added domain: markdown Related to Markdown parsing or syntax difficulty: intermediate Issues that are medium difficulty level, e.g. moderate refactoring with a clear test plan. status: blocked This issue is blocked by another issue or external dep and can't be pushed further. and removed difficulty: advanced Issues that are complex, e.g. large scoping for long-term maintainability. labels Apr 3, 2022
@Josh-Cena Josh-Cena mentioned this issue Apr 20, 2022
Merged
@balogun14
Copy link

can you explain this issue a bit more @slorber

@slorber
Copy link
Collaborator Author

slorber commented Sep 28, 2023

can you explain this issue a bit more @slorber

This is not really an issue for first-time contributors @balogun14, I take notes for myself to solve this problem on my own later.

@balogun14
Copy link

@slorber Thank you for the response i will check other issues then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug An error in the Docusaurus core causing instability or issues with its execution difficulty: intermediate Issues that are medium difficulty level, e.g. moderate refactoring with a clear test plan. domain: markdown Related to Markdown parsing or syntax status: blocked This issue is blocked by another issue or external dep and can't be pushed further.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@slorber @Josh-Cena @balogun14