Explicitly exclude node_modules/ in ESLint configuration #9310
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although ESLint excludes
node_modules/
by default when actually linting, theoverrides
rule for TypeScript does scan the dependencies when looking for TypeScript files (usingfiles: '**/*.ts?(x)'
). That means that, even if the linted code contains no TypeScript at all, the override triggers. An attempt to load@typescript-eslint/parser
is made, which fails due to TypeScript not being installed.This PR adds an explicit top-level ignore for
node_modules/
, which appears to prevent this (tested with a vanilla app made usingnpx create-react-app@latest
).Fixes #8745, #8936.