Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly exclude node_modules/ in ESLint configuration #9310

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Explicitly exclude node_modules/ in ESLint configuration #9310

wants to merge 1 commit into from

Conversation

textbook
Copy link

Although ESLint excludes node_modules/ by default when actually linting, the overrides rule for TypeScript does scan the dependencies when looking for TypeScript files (using files: '**/*.ts?(x)'). That means that, even if the linted code contains no TypeScript at all, the override triggers. An attempt to load @typescript-eslint/parser is made, which fails due to TypeScript not being installed.

This PR adds an explicit top-level ignore for node_modules/, which appears to prevent this (tested with a vanilla app made using npx create-react-app@latest).

Fixes #8745, #8936.

@facebook-github-bot
Copy link

Hi @textbook!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@textbook
Copy link
Author

Alternatively it could add excludedFiles: 'node_modules/**/*.ts?(x)' inside the override.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

eslint-config-react-app > @typescript-eslint/parser missing typescript?
4 participants