Upgrade testing-library packages#8406
Merged
ianschmitz merged 5 commits intofacebook:masterfrom May 4, 2020
gnapse:upgrade-jest-dom-version
Merged
Upgrade testing-library packages#8406ianschmitz merged 5 commits intofacebook:masterfrom gnapse:upgrade-jest-dom-version
ianschmitz merged 5 commits intofacebook:masterfrom
gnapse:upgrade-jest-dom-version
Conversation
gnapse
requested review from
amyrlam,
ianschmitz,
iansu,
mrmckeb and
petetnt
as code owners
ianschmitz
changed the title
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jest-dom's latest major version has its type definitions moved to DefinitelyTyped (see testing-library/jest-dom#123). This make it so the TypeScript definitions work automatically without config. This PR upgrades the version referenced in the template so that newly generated projects get the newest version right from the start.The newest
jest-domversion also makes it so that the main module takes care of extendingexpect, so this PR includes the following change where appropriate (though the usual way still works):This PR also takes the liberty to upgrade the actual dev dependency of
create-react-appitself. Ran the tests and it all worked. Hope that's ok too.