Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webpackHotDevClient now uses wss when https is used #8079

Merged
merged 1 commit into from
Dec 5, 2019

Conversation

mikecaulley
Copy link
Contributor

@mikecaulley mikecaulley commented Dec 5, 2019

Fixes #8075.

Summary

  • If https protocol is being used we should use WebSockets over SSL/TLS (WSS) protocol instead of WebSockets (WS)

Test Plan
Follow steps in the issue #8075

@facebook-github-bot
Copy link

Hi mikecaulley! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Copy link

@dimaqq dimaqq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes perfect sense!

@ianschmitz ianschmitz added this to the 3.3.1 milestone Dec 5, 2019
@ianschmitz ianschmitz changed the title webpackHotDev now uses wss when https is used webpackHotDevClient now uses wss when https is used Dec 5, 2019
@ianschmitz ianschmitz merged commit 9f4cb4f into facebook:master Dec 5, 2019
@ianschmitz
Copy link
Contributor

Ah yes. Great catch. Thanks @mikecaulley!

@esetnik
Copy link

esetnik commented Dec 5, 2019

Can a maintainer cut v3.3.1 release with this change please?

@justingrant
Copy link
Contributor

Some client libraries like Facebook Login SDK will fail if run over non-HTTPS connections (even on localhost!). This makes 3.3.0 a problem for users of these libraries because they can't fall back to HTTP, even in DEV mode. So would be cool to get this patch released soon. Thanks!

For folks who end up here from Google, while waiting for a patch you can manually edit node_modules/react-dev-utils/webpackHotDevClient.js to fix this problem without downgrading to 3.2. Here's the code you'll want at line 62 of that file:

protocol: window.location.protocol === 'https:' ? 'wss' : 'ws',

@lock lock bot locked and limited conversation to collaborators Dec 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Websocket with wrong protocol on HTTPS Development ENV
6 participants