Skip to content

Revert logo in templates #7830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 16, 2019
Merged

Revert logo in templates #7830

merged 1 commit into from
Oct 16, 2019

Conversation

iansu
Copy link
Contributor

@iansu iansu commented Oct 16, 2019

@iansu iansu mentioned this pull request Oct 16, 2019
Merged
@iansu iansu added this to the 3.3 milestone Oct 16, 2019
petetnt
petetnt approved these changes Oct 16, 2019
View reviewed changes
Copy link
Contributor

@petetnt petetnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and makes sense in retrospect

@iansu iansu mentioned this pull request Oct 16, 2019
Closed
19 tasks
@iansu iansu merged commit 584e352 into facebook:master Oct 16, 2019
@iansu iansu deleted the revert-template-logo branch October 16, 2019 16:25
@lock lock bot locked and limited conversation to collaborators Oct 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ianschmitz ianschmitz Awaiting requested review from ianschmitz

@mrmckeb mrmckeb Awaiting requested review from mrmckeb

2 more reviewers

@andriijas andriijas andriijas approved these changes

@petetnt petetnt petetnt approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
CLA Signed tag: internal
Projects
None yet
Milestone
3.3
Development

Successfully merging this pull request may close these issues.
4 participants
@iansu @andriijas @petetnt @facebook-github-bot