-
-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade babel-eslint #7594
Upgrade babel-eslint #7594
Conversation
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Sorry if this is the wrong place for this comment, but is there a reason why these versions don't have a caret? Is there a documented reason for |
@avindra I was wondering the same thing. Happy to change this PR to a caret if there's no good reason why it is pinned. |
Actually the whole problem is caused by the If both pinned, the issue won't occur since So if both use @esetnik @avindra Beside from the issue itself, use |
I suggest also pinning |
Well, beside discussion, I think we should merge this PR and solve the problem ASAP, since it blocks people to upgrade to the new version just because of false positive eslint issues, which could failed the build in CI env. |
Any update on this one? Waiting for merge and a new release. |
@silverwind It won't take much work, but it take time to release. As you can see, this PR has not been merged yet. And even after this PR been merged, it will only be fixed in the next release. Which means, somebody using it may blocked for days or weeks. |
I second @yyfearth on the urgency of this one. I could be wrong, but the cleanest way I could find to temporarily fix this issue was to add a pinned old version of I can't believe other people aren't pushing for this more. I wonder what other people have done to temporarily solve this, and if they've done something similar to what I have, why they think that's okay. |
I always remove carret from all dependencies to pin the version, and considering it as good proctice, which is really saves time on resolving consequent deploys to dev prod an local environments with yarn. |
Still no action on this one? Blocked for weeks. |
How is a linter warning blocking you, @yyfearth? |
@tremby It blocks me to upgrade CRA from 3.0.1 to 3.1.1 only because the eslint change, which produce tons of false positive warnings. |
@yyfearth if you are using yarn, you can specify You'll also need to set the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it support migration with all other libraries?
Fixes #7566
See eslint/eslint#12117