Handle typescript errors in react-error-overlay #7091
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaykayehnn
requested review from
amyrlam,
bugzpodder,
gaearon,
ianschmitz,
iansu,
mrmckeb,
petetnt and
Timer
as code owners
kaykayehnn
commented
May 21, 2019
| @@ -7,7 +7,7 @@ export type ErrorLocation = {| | |||
| colNumber?: number, | |||
| |}; | |||
|
|
|||
| const filePathRegex = /^\.(\/[^/\n ]+)+\.[^/\n ]+$/; | |||
| const filePathRegex = /^(?:\.|[A-Z]:)?(\/[^/\n ]+)+\.[^/\n ]+$/; | |||
There was a problem hiding this comment.
This regex should match both relative and absolute paths on all platforms.
(?:\.|[A-Z]:)? defines an optional non-capturing group which may contain either a period (for matching relative paths) or a Windows drive letter for matching absolute paths. I verified that Windows does not support drive letters after Z.
Unix absolute paths (/path/to/folder) are also matched correctly as the first group is optional.
Timer
reviewed
Mar 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7082