Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional troubleshooting for Github Pages #5169

Merged
merged 2 commits into from
Sep 29, 2018
Merged

Add additional troubleshooting for Github Pages #5169

merged 2 commits into from
Sep 29, 2018

Conversation

dwang
Copy link

@dwang dwang commented Sep 29, 2018

Properly solves #5038

The gh-pages error message is misleading because my git user.email was already set.
I needed to set my git user.name as well to solve the issue.

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@Timer Timer added this to the 2.0.0 milestone Sep 29, 2018
@Timer
Copy link
Contributor

Timer commented Sep 29, 2018

Thanks!

@Timer Timer merged commit 7f5ec49 into facebook:master Sep 29, 2018
zmitry pushed a commit to zmitry/create-react-app that referenced this pull request Sep 30, 2018
* Add additional troubleshooting for Github Pages

* Update README.md
@lock lock bot locked and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants