Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[internal] Fix node 10 test issue #4626

Merged
merged 4 commits into from
Jun 18, 2018
Merged

[internal] Fix node 10 test issue #4626

merged 4 commits into from
Jun 18, 2018

Conversation

bugzpodder
Copy link

Replace npm-login-cli with npm-auth-to-login, which works with node 10.
Should fix #4383

Jack Zhao and others added 2 commits June 4, 2018 11:10
@iansu
Copy link
Contributor

iansu commented Jun 18, 2018

Thanks for fixing this. It's been on my todo list. I was looking at submitting a PR to npm-login-cli but it looks like that project isn't very active. This seems like a better solution.

@bugzpodder
Copy link
Author

It seems Travis is acting up these days. I've seen quite a bit of random failures on my PRs and other PRs that involves only trivial text changes.

@iansu
Copy link
Contributor

iansu commented Jun 18, 2018

I've noticed this as well. It looks like @Timer might have a potential fix.

@iansu
Copy link
Contributor

iansu commented Jun 18, 2018

Given that this passed on Appveyor I'm happy to merge it.

@Timer
Copy link
Contributor

Timer commented Jun 18, 2018

Yeah, we need to get CI working reliably.

@Timer Timer added this to the 2.0.0 milestone Jun 18, 2018
@Timer Timer merged commit e1ee803 into facebook:next Jun 18, 2018
@bugzpodder bugzpodder deleted the node10 branch June 18, 2018 18:09
@lock lock bot locked and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants