Chokidar Updates #4205
Chokidar Updates #4205
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
/cc @michaelwayman I would love your LGTM |
| @@ -584,7 +584,7 @@ To enable importing files without using relative paths, you can add the `--incl | |||
|
|
|||
| ``` | |||
| "build-css": "node-sass-chokidar --include-path ./src --include-path ./node_modules src/ -o src/", | |||
| "watch-css": "npm run build-css && node-sass-chokidar --include-path ./src --include-path ./node_modules src/ -o src/ --watch --recursive", | |||
| "watch-css": "node-sass-chokidar --include-path ./src --include-path ./node_modules src/ -o src/ --watch --recursive", | |||
There was a problem hiding this comment.
Remove another --recursive flag here
There was a problem hiding this comment.
the --recursive flag was removed in 1.0.0 and recursion is always on because there is no way to be non-recursive with chokidar.
Other than that this LGTM
There was a problem hiding this comment.
also the --include-path ./src isn't necessary, let's say you have files ./src/index.scss and ./src/_mixins.scss and in index.scss you @import './_mixins' it will still import correctly.
You don't necessarily need the --include-path ./src
Thanks @originell for keeping the docs updated with node-sass-chokidar, it had slipped my mind.
|
Changes landed. Also found another |
|
@Timer LGTM |
|
Do we want this going into |
|
This should go ahead and get merged now. |
|
@iansu We don't plan to make more changes to master aside from critical fixes. |
According to the changelog it is not necessary anymore as it doesn't do anything.
Chokidar now does this on it's own.
* Removes Chokidar Recursive Flag According to the changelog it is not necessary anymore as it doesn't do anything. * Removes initial build on SCSS watch Chokidar now does this on it's own. * Removes sass watch recursive, default include-path as proposed by @michaelwayman * Removes another left-over build-css
There have been a couple of changes to
node-sass-chokidarover the recent days.The following things have been changed, according to the
node-sass-chokidar/CHANGELOG:--recursiveflag removed as it doesn't do anything (CHANGELOG v1.0.0)watch-css, as chokidar changed the behaviour (CHANGELOG v1.0.0)🍻