E2E testing enhancements #2408
E2E testing enhancements #2408
Conversation
I tried to reproduce this and wasn't able to. So just ignore that comment, if I come across it again / can reproduce I'll let you know. |
|
Actually, can confirm that the errors are being passed correctly. The error I saw was only because I had edited the tmp files directly. Happy to review your readme etc when its ready. Just ping me. Thanks again for your help debugging the e2e stuff. |
EnoahNetzach
force-pushed
the
local-testing
branch
from
977e8f4
to
45df6bf
Compare
There was a problem hiding this comment.
Looks really good!
Just some minor thoughts/tweaks.
Still wonder if its possible to direct people to where the test failed test, development, production or eject when it does fail. Just since people often skip readme's. Although it might have just been a rare edge case (or stupidity) where it wasn't obvious that test was failing rather than development / production.
| This is a simple script that runs a **Docker** container, where the node version, git branch to clone, test suite, and whether to run it with `yarn` or `npm` can be chosen. | ||
| Simply run `yarn e2e:docker -- --help` to get additional info. | ||
|
|
||
| N.B.: this command will clone the local repository in the docker container, so any uncommitted changes are ignored. |
There was a problem hiding this comment.
Is there a way to run this on uncommitted changes. As normally I'd make changes, write tests, run tests. And then if everything works commit changes.
With this, I'd be making changes, committing, testing, making changes, committing, testing, etc.
There was a problem hiding this comment.
Yep, coming soon!
CONTRIBUTING.md
Outdated
| ## Contributing to E2E (end to end) tests | ||
|
|
||
| All information are in the dedicated [README](/packages/react-scripts/fixtures/kitchensink/README.md). | ||
|
|
There was a problem hiding this comment.
Is it worth putting in a TL:DR?
TL:DR use the command
yarn e2e:dockerto run unit and e2e tests
|
Thanks for this! |
|
Can you add info on how to setup Docker for this? At least a link. I can't seem to figure it out. |
|
Do you mean how to setup Docker itself on various OSes? |
|
I guess I'll try official instructions (linking to them would be welcome). |
|
https://docs.docker.com/engine/installation/, I'll link them in the docs in a minute |
|
https://docs.docker.com/docker-for-mac/install/ specifically for Mac |
|
FWIW |
* Local testing with docker * Docs on e2e testing * `bash` callback after docker * Add a TL;DR in the CONTRIBUTING section * Local e2e testing with modified files * Remove the N.B. from the README * Fixed a fixme in e2e doc
* Local testing with docker * Docs on e2e testing * `bash` callback after docker * Add a TL;DR in the CONTRIBUTING section * Local e2e testing with modified files * Remove the N.B. from the README * Fixed a fixme in e2e doc
* Local testing with docker * Docs on e2e testing * `bash` callback after docker * Add a TL;DR in the CONTRIBUTING section * Local e2e testing with modified files * Remove the N.B. from the README * Fixed a fixme in e2e doc
Features to add:
local testing with docker
bashcallback after the docker entrypointdocs explaining how testing is managed and how to contribute
test modified files