Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot add license key to generated package.json file in template #9849

Open
lerickson-ds opened this issue Oct 21, 2020 · 2 comments
Open

Comments

@lerickson-ds
Copy link

Describe the bug

When using the 4.0 alpha, I cannot figure out a way to add a license key to the package.json file in the template. Therefore when I create a project with my create-react-app template it always gives me the "warning ../../package.json: No license field" warning. Please add the ability to add a license key in the template.json file of the templates or let me know if there is already a way to achieve this.

Steps to reproduce

(Write your steps here:)

  1. Using the 4.0 alpha of create-react-app and a custom template, add license key in template.json
  2. Create a project with your custom template
  3. Run 'yarn start'

Expected behavior

To start up with no warnings and have a "license" key in the package.json file.

Actual behavior

It started up, but with the "warning ../../package.json: No license field" warning and does not have a "license" key in the package.json file.

@stale
Copy link

stale bot commented Dec 25, 2020

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@stale stale bot added the stale label Dec 25, 2020
@lerickson-ds
Copy link
Author

This is still an issue, please leave it open. I will try to create a PR soon.

@stale stale bot removed the stale label Dec 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant