Long path support issues on windows when using npm3

[gertjvr]

Description

TL;DR when using npm3 node packages should not include their dependencies. ie shouldn't have a sub node_modules folder. on windows this can cause long path names. longer than what windows can support.
npm guidance https://docs.npmjs.com/how-npm-works/npm3

Long story but we use cake build scripts and it doesn't support long files paths on windows. We have had a similar issue recently when phantomjs broken release.

Environment

1. npm ls react-scripts (if you haven’t ejected): react-scripts@0.7.0
2. node -v: v4.4.5 / v6.9.1
3. npm -v: v3.7.1 / v3.10.8

Then, specify:

1. Operating system: Windows 10 and Windows Server 2012

node_modules structure after npm install

[gertjvr]

Guess I am the only windows user of cra 😄

[gaearon]

I don’t think so. I haven’t had time to reply because I’m focusing on React itself this quarter and so this repo is less actively maintained.

It’s not clear to me why this happens. Do you have any idea? I thought npm3 is supposed to try flat structure when possible.

[gertjvr]

I have tried using yarn and it does exactly the same react-scripts ends up with multiple nested node_modules folders causing the long path name issues.

[thien-do]

NPM do try flat structure if possible, so I think it is because of bundledDependencies.

Also, actually it is only nested 3 levels of node_modules, as the longest path (258 characters) is:

C:\TeamCity\buildAgent\work\82a0aa7e218f78a7\src\{APPLICATION_NAME[29]}
\node_modules\react-scripts
\node_modules\babel-preset-react-app
\node_modules\babel-plugin-syntax-trailing-function-commas\test\fixtures\trailing-function-commas\new-expression\expected.js

seems because babel-preset-react-app is bundled into react-scripts by purpose, so NPM don't try to flat them?

UPDATE:

One thing I noted that in my system, babel-plugin-sysntax-trailing-function-commas is at the same level with babel-preset-react-app. Not sure why in @gertjvr's case it is nested.. maybe that is the issue, not the bundledDependencies of react-scripts..

[gertjvr]

@dvkndn I am pretty new to node and how the packaging system works, how do you control the bundledDependencies as a package author? I referenced the phantomjs case but its not clear how they solved the issue. might have to do more reading.

[gertjvr]

@dvkndn @gaearon I see what you mean downgrading to v0.6.0 solved the issue for us and on closer inspection v0.6.0 didn't have any bundledDependencies.

[gaearon]

We control bundledDependencies. We added them to cut the install time on npm 2. However now that Node 6 is the LTS release (and comes with npm 3) it may be a good time to drop support for npm 2 and remove bundledDependencies.

[thien-do]

Yes remove bundledDependencies also help solve several bugs relating when forking CRA.

[gaearon]

Tagging this as 0.8.0 since that's the release where we should remove bundledDependencies and drop npm 2 support. cc @fson

[fson]

Bundled dependencies were removed in #1068 so this should be fixed in the upcoming release.