Auto deploy docs preview for every PR

[iansu]

It would be nice to be able to see a preview of the docs when someone submits a change. We should be able to set that up using something like Netlify.

[iansu]

Maybe @sw-yx can help us out with this?

[swyxio]

hey! yea sure. really you just have to push this up on Netlify and its a button click away. do you want to do it on your own account? if i do it on mine i don't think i can transfer it over to you.

just let me know when youve done it and i'll put you on the free OSS plan.

[iansu]

That's something we need to figure out. Do we also need to install something in the GitHub repo so the link to the deploy appears on each PR? If so we'll need to ask @gaearon to do that.

[swyxio]

hmm. might need to install the Netlify Github app, yes. but it might already be installed since reactjs.org is on netlify.

[iansu]

At the very least it will be easier to convince someone to install it if React is already using it.

[swyxio]

alright lets wait for Dan to see this. sounds like you do need an install

[gaearon]

I don't know what to do with this. If someone gives me exact instructions I can set it up. :-)

[iansu]

I'll see if I can get this working with my fork of CRA and post some more specific instructions.

[swyxio]

@gaearon and @iansu apologies for the confusion. some setup was needed to deploy this monorepo/docusaurus setup. the best way to do this is with a netlify.toml configuration - in #5930 i have created a PR to set that up in CRA.

You can see the result of this deploy here: https://trusting-lichterman-ee04c1.netlify.com

• it is deployed from my fork of CRA, and i have enabled the PR deploy preview setting so that you can see how it might look when someone makes a PR into the docs:
• Bump lodash from 4.17.11 to 4.17.15 in /docusaurus/website swyxio/create-react-app#1 (look at the netlifybot comment that says "hello ian!" you can customize this message) - so you can preview the site if you merged the PR
• deploy logs are open so people will be able to tell if they made a PR that fails the build. and members of the Netlify "react" team should be able to make other settings adjustment.
• no bandwidth worries b/c you'd be on the unofficial "OSS plan"
• every deployment has an immutable URL which is what reactjs.org uses for versioning docs
• i was forced to set a redirect from / to /create-react-app because of the baseUrl setting in docusaurus - if we do proceed with netlify we can get rid of that.

[iansu]

This is awesome. Thanks! 🎉

I think the baseUrl is set to /create-react-app because we're deploying to GitHub pages.

What do we need to do to get this finished? I see that Dan has already merged your config PR. What else do you need from us?

[swyxio]

just need to proceed with the deploy :) You or Dan can do it since you should be on the "react team" within Netlify.

• https://app.netlify.com/start
• hit Github
• choose the facebook org and search for the c-r-a repo
• that will get you to where dan was above but this time you dont need to write any build settings, its done for you by the config. leave the settings blank and just hit "Deploy site".

Once its deployed we can worry about naming. Do you want create-react-app.netlify.com? or do you want some more custom domain? (cra.io?) could even consider facebook.netlify.com/create-react-app. we have someone squatting on https://cra.netlify.com/ but we could boot them if you want.

[iansu]

Deployed! I'm not sure about the domain name right now. I think we will continue using the GitHub pages URL until we come up with something better. This is a great start though. Now we can preview the docs when someone submits a PR. 🎉