Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Jest's --watchAll #3801

Closed
mikew opened this issue Jan 15, 2018 · 5 comments
Closed

Support Jest's --watchAll #3801

mikew opened this issue Jan 15, 2018 · 5 comments

Comments

@mikew
Copy link

mikew commented Jan 15, 2018

Jest, at least the version that react-scripts depends on, does not work with both the --watch and --watchAll flags.

Since react-scripts is automatically adding the --watch flag, that means no user would ever be able to do --watchAll.

Either upgrading Jest or fixing this logic would solve the issue.

@GAumala
Copy link
Contributor

GAumala commented Jan 15, 2018

Yes, but in watch mode, after the initial run you can press 'a' to trigger a "watchAll" run.

@gaearon
Copy link
Contributor

gaearon commented Jan 15, 2018

Yes, but in watch mode, after the initial run you can press 'a' to trigger a "watchAll" run.

Yea, IMO this is enough.

@gaearon gaearon closed this as completed Jan 15, 2018
@mikew
Copy link
Author

mikew commented Jan 15, 2018

IMO it's not, but whatever I guess?

@mikew
Copy link
Author

mikew commented Jan 15, 2018

Yes, but in watch mode, after the initial run you can press 'a' to trigger a "watchAll" run.

Yes, but what if you don't want to have to wait for Jest to start up and press a key to run all tests?

@gaearon
Copy link
Contributor

gaearon commented Jan 15, 2018

Merged a fix in #3804. Will be out in 2.x beta.

@lock lock bot locked and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants