-
-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show a transparent overlay with development warnings #1888
Comments
It'll show in the website the user is developing @Timer ? If yes, a full screen overlay shows every time when there are warnings ? |
Warnings won't take over the screen like an error. The idea is to make less-intrusive version of the crash overlay which appears for runtime warnings, and maybe compile warnings. Basically, only when in development mode, there would be a small pop-up on screen (which is unobtrusive). Hovering it would display more context and clicking would "pop" it into a full screen overlay like crash overlay. Think toastr. |
Cool, Okay 👍 |
I would hold off implementing this because we might want to build something like this into React itself. @bvaughn experimented with it. It’s going to be confusing if these efforts are not aligned. |
Nothing yet on our end, @viankakrisna, although I plan to pick it back up soon. |
Thanks! sent a PR 😄 IIRC the React ones gonna be about React's own warning right? |
Depends. We haven't decided yet what the error/warning API will look like for 16. Would be nice if CRA (and maybe other 3rd party libs) could piggy-back on React's warning system. |
Ok, I'll leave it to the maintainers about my overlay then. Excited to see how it will be implemented though :) |
We have exposed frames for react 16 warnings in facebook/react#13242 and react-error-overlay can now take advantage of them in a future rewrite |
Any movement on this? It's quite annoying that warnings break the simple workflow of clicking in the terminal to open the browser tab. |
As proposed here, maybe we should have a transparent "warning overlay" which is dismiss-able.
The text was updated successfully, but these errors were encountered: