Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show a transparent overlay with development warnings #1888

Open
Timer opened this issue Mar 23, 2017 · 11 comments
Open

Show a transparent overlay with development warnings #1888

Timer opened this issue Mar 23, 2017 · 11 comments

Comments

@Timer
Copy link
Contributor

Timer commented Mar 23, 2017

As proposed here, maybe we should have a transparent "warning overlay" which is dismiss-able.

@Timer Timer added this to the 0.10.0 milestone Mar 26, 2017
@hamxabaig
Copy link

It'll show in the website the user is developing @Timer ? If yes, a full screen overlay shows every time when there are warnings ?

@Timer
Copy link
Contributor Author

Timer commented Apr 25, 2017

Warnings won't take over the screen like an error.

The idea is to make less-intrusive version of the crash overlay which appears for runtime warnings, and maybe compile warnings.

Basically, only when in development mode, there would be a small pop-up on screen (which is unobtrusive). Hovering it would display more context and clicking would "pop" it into a full screen overlay like crash overlay.

Think toastr.

@hamxabaig
Copy link

Cool, Okay 👍

@gaearon
Copy link
Contributor

gaearon commented May 8, 2017

I would hold off implementing this because we might want to build something like this into React itself. @bvaughn experimented with it. It’s going to be confusing if these efforts are not aligned.

@gaearon gaearon modified the milestones: 0.11.0, 0.10.0 May 8, 2017
@viankakrisna
Copy link
Contributor

@bvaughn @gaearon any update on the warnings? I've got my hands free and build this for CRA's lint warning.

jul-13-2017 03-20-34

@bvaughn
Copy link
Contributor

bvaughn commented Jul 12, 2017

Nothing yet on our end, @viankakrisna, although I plan to pick it back up soon.
Your overlay looks nice! 😄

@viankakrisna
Copy link
Contributor

viankakrisna commented Jul 12, 2017

Thanks! sent a PR 😄 IIRC the React ones gonna be about React's own warning right?

@bvaughn
Copy link
Contributor

bvaughn commented Jul 12, 2017

Depends. We haven't decided yet what the error/warning API will look like for 16. Would be nice if CRA (and maybe other 3rd party libs) could piggy-back on React's warning system.

@viankakrisna
Copy link
Contributor

Ok, I'll leave it to the maintainers about my overlay then. Excited to see how it will be implemented though :)

@swyxio
Copy link
Contributor

swyxio commented Jul 19, 2018

We have exposed frames for react 16 warnings in facebook/react#13242 and react-error-overlay can now take advantage of them in a future rewrite

@Timer Timer modified the milestones: 2.0.x, 2.x Sep 26, 2018
@Timer Timer removed this from the 2.x milestone Nov 2, 2018
@ghost
Copy link

ghost commented Jul 20, 2021

Any movement on this? It's quite annoying that warnings break the simple workflow of clicking in the terminal to open the browser tab.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants