`npm run build` silently fails on OOM

[brandones]

Description

When running npm run build, if the system runs out of memory...

Expected behavior

It should exit with a non-zero return code.

Actual behavior

The process exits return code 0.

Environment

1. npm ls react-scripts: 0.7.0
2. node -v: v6.9.5
3. npm -v: 3.10.10

Then, specify:

1. Operating system: Ubuntu 16.04
2. Browser and version: n/a

Reproducible Demo

Try building on a tiny VM.

See #1026

[gaearon]

Agreed it’s an issue, do you have any idea how to solve this?

[brandones]

Well, it looks like react-scripts build runs node build.js, and when you send SIGTERM to the latter process (as happens with an OOM) it exits silently. Default behavior for node on SIGTERM (aka signal 15) is to exit 15. So this script is probably catching SIGTERM somewhere and exiting "gracefully."

[brandones]

Adding

 process.on('SIGTERM', function () {
   process.exit(15);
 });

to the end of react-scripts/scripts/build.js fixes the problem. I'll add a couple more signals, console.log an error message, and submit a pull request -- cool? Is there a cleanup hook I should call?

[gaearon]

@brandones Sounds great, thanks!

[gaearon]

Can we consider this resolved by #1496?

[gaearon]

Going to close in hope it’s resolved but please reopen if not.